From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2464C282C0 for ; Wed, 23 Jan 2019 20:47:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEC1121872 for ; Wed, 23 Jan 2019 20:47:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="RzOrtcEt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbfAWUrR (ORCPT ); Wed, 23 Jan 2019 15:47:17 -0500 Received: from mail-pg1-f172.google.com ([209.85.215.172]:47085 "EHLO mail-pg1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726243AbfAWUrQ (ORCPT ); Wed, 23 Jan 2019 15:47:16 -0500 Received: by mail-pg1-f172.google.com with SMTP id w7so1586558pgp.13 for ; Wed, 23 Jan 2019 12:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wcFw/d2t0NrDpdh719UTFWE50PbVCgSRUw7qqPmSCYY=; b=RzOrtcEt+iZ29vL8FSsy6Z16Y8MhrzfHNHtaKnlTqyGrlhZazq+zUVTHVHHlG/vfbs xq8Kzc+VoExWYX5nCKDuJ8ggE/Ha+8qBkAZx0w4PT2mcFoTal/EH/G8FFsz6phdAf0o+ 1ahSXhpA38+ydxXXruvzfCrTDwrpWqNIsHUdP7NfZYMZgnPatETUBQx2N7qbZbXVT8Ln vNR2pqHA4NrTyZmrvwsHjP2yxo7z0VEqopO9SOSSd/Kx3KUwPvaM9UIJAh4b+59Ca47F R7kRykEMh8d84UChDJJuQWSM3tOEsRxd+efUDe1QSeorsPFWLB2pLGGC0gRTznsHz4QD ci3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wcFw/d2t0NrDpdh719UTFWE50PbVCgSRUw7qqPmSCYY=; b=Zo66u1xuB4utfQq4QsEAmRbFHG2eXwFGHOjA8Cbn0BEo2RnApQYA75YxxRmkdwI0MQ 8G/06I3oxgzIyDeFlP4LavECmmn/3HtAWxOerjaY+Tl75cdrzjabZrUJkDUP4hkX9w5X 2i60a44Ped/9S1TWJjoS8wQYLZIntYEJUkX4efpHv4EOZxPHDrYv99Cfz8Gwt01lh0NU dsemrD5B8iuwDqtRaWQaPTnNT35s/pXN9+e797ZXaWSHMOUZy3dZ7eW9ZR/pOksDgt0C 4Z4gfLBESomDPuq6/ysTUKE9OFjgxelIsY4F+oXwBpMa8raCXiQ7pcfCeY2/2Vadbg3u 5SQQ== X-Gm-Message-State: AJcUukfpoKF/KlhxCGMkeV6yRtUgJTKplrf87GXJr5HA8DBEG94koyBJ mdhE86IRrB17SO6S1WpFOK6LZw== X-Google-Smtp-Source: ALg8bN55XzO16L2zngujlThpvyeeEzb/QApnWrebA+FZ+O8hEWQc4TyFySlSAyiV7fRbJv/haNHyCA== X-Received: by 2002:a62:59c9:: with SMTP id k70mr3536554pfj.243.1548276435737; Wed, 23 Jan 2019 12:47:15 -0800 (PST) Received: from shemminger-XPS-13-9360 ([202.36.179.100]) by smtp.gmail.com with ESMTPSA id w128sm25686632pfw.79.2019.01.23.12.47.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 12:47:15 -0800 (PST) Date: Thu, 24 Jan 2019 09:47:06 +1300 From: Stephen Hemminger To: Cong Wang Cc: netdev@vger.kernel.org, Martin Olsson , Jamal Hadi Salim , Jiri Pirko , David Ahern Subject: Re: [Patch iproute2] tc: add hit counter for matchall Message-ID: <20190124094706.57050b51@shemminger-XPS-13-9360> In-Reply-To: <20190117211855.31030-1-xiyou.wangcong@gmail.com> References: <20190117211855.31030-1-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 17 Jan 2019 13:18:55 -0800 Cong Wang wrote: > > + if (tb[TCA_MATCHALL_PCNT]) { > + if (RTA_PAYLOAD(tb[TCA_MATCHALL_PCNT]) < sizeof(*pf)) { > + print_string(PRINT_FP, NULL, "Broken perf counters\n", NULL); This the wrong way to print an error message with iproute2 suite. The correct answer is simple. fprintf(stderr, "Broken perf counters\n"); and better yet give a more informative message that says what is incorrect.