From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A94CCC282C3 for ; Thu, 24 Jan 2019 18:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 63DF9218A2 for ; Thu, 24 Jan 2019 18:51:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="C+NShV4v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726049AbfAXSvA (ORCPT ); Thu, 24 Jan 2019 13:51:00 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:40585 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbfAXSu7 (ORCPT ); Thu, 24 Jan 2019 13:50:59 -0500 Received: by mail-qt1-f196.google.com with SMTP id k12so7838413qtf.7 for ; Thu, 24 Jan 2019 10:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=i9OrwljJRHVsZaSmnb5jTUl/KVI9O8eyx0WRnGuctE4=; b=C+NShV4v1l9e8b14NaO6H5XzXPV7wjfw8msDcjNNxlme5Px5F5IIxDp4ffDySAOJi6 uKL9vCRPVE7M4UZZp54mwddsISO9nGhW4gV6+AWnLuUTcS/xi28aimoqqpP6wa+orHa/ mV6zAykOxIFv6MrdGVVod4sWJzp2M7slp/2ZqzPB3SgQtQloXWYrkJjyNb9eT0Y+gmF+ lbZHsDVFvaLR2Z5re5IvOT9Lb4VrKYrCh+QZcQSc+nI2FFz3ILPwwcfjFXwF/popA9kl vX9dsvlNkPjjFgTQ5UtXLE8MRGdtw+NB99o+MDmeHLdBvwbaZk5NkmbAjpzVfWbPSLvC 3wNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=i9OrwljJRHVsZaSmnb5jTUl/KVI9O8eyx0WRnGuctE4=; b=Y9J9gRkv+Vp4x2D5bwREwvbAnLL6yV421NON3f7hJf4m7PP96PuNARW2ghRWB3HZgV XEq3XPUDWcVa9gethhQBa5BnqBxD0sLV1ytDpt7o+CcvjaD6SZNrKJKROgYVdU8AdV6s MXiqXXoAJSzmeuJThqwM3/qIkH2RXRm6hbkZsFKdE1nQ28sl7XVj/COV6AxTE0MMNXm5 ajeatOifBM001YWK/TMQRhAvwxo3Aed3SrXsv1O01ngP/XRETlwQyFXMR+fhT6L8cMIG x0ess+HSGl/tZRu+IM8cnxfWhNc/qbo9HphJ4mt0NReMflzlxhmD2qrcHYZ32BJMi3kZ D/SQ== X-Gm-Message-State: AJcUukdmIDB/EOEKNOwTQ/ELWgAKjNPtui2pgtVHYiMzF1CW/KDluqPu Bo+4FMym4B2J4a9hr6vUFXBQFg== X-Google-Smtp-Source: ALg8bN7Dxj4uziIMuHOn0iO4OqMl2c+YqFRD73jpTzgdmnSfZ7zK1NO7hpbLXR8sZFBae7IPLc2hcA== X-Received: by 2002:aed:3324:: with SMTP id u33mr2366301qtd.161.1548355858401; Thu, 24 Jan 2019 10:50:58 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id j36sm75147662qtk.15.2019.01.24.10.50.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jan 2019 10:50:58 -0800 (PST) Date: Thu, 24 Jan 2019 10:50:52 -0800 From: Jakub Kicinski To: Vasundhara Volam Cc: Michal Kubecek , Netdev , David Miller , "michael.chan@broadcom.com" , Jiri Pirko Subject: Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port Message-ID: <20190124105052.3a5bca7a@cakuba.netronome.com> In-Reply-To: References: <1547795385-12354-1-git-send-email-vasundhara-v.volam@broadcom.com> <20190118143319.GG26670@unicorn.suse.cz> <20190122141842.26908b27@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 24 Jan 2019 15:16:27 +0530, Vasundhara Volam wrote: > > > > The devlink WoL setting does not have to match the ethtool WoL > > > > setting. > > > > > > IMHO this is not really a problem. We can either use an additional flag > > > telling kernel/driver if we are setting runtime or persistent WoL mask > > > or we can pass (up to) two bitmaps. > > > > I think reusing new netlink ethtool with a special flag would be a nice, > > complete solution. We could also address link settings this way (which > > are a pre-requisite for WoL). > > > > I have no strong preference on the mechanism, but for ease of setting > > as well as dumping would it be workable to use a nesting, like this: > > > > Run time settings: > > [ETHTOOL_SETTINGS_BLA] > > [ETHTOOL_BLA_VAL_1] > > [ETHTOOL_BLA_VAL_2] > > ... > > > > Persistent: > > [ETHTOOL_PERSISTENT] > > [ETHTOOL_SETTINGS_BLA] > > [ETHTOOL_BLA_VAL_1] > > [ETHTOOL_BLA_VAL_2] > > > > IOW encapsulate settings into a "persistent" attribute? > Not sure if current devlink framework allows to encapsulate additional > settings now. > But we can think of extending it to support this when there is a requirement. To be clear the question was to Michal and about ethtool netlink, where this configuration belongs.