From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0DFDC282C3 for ; Thu, 24 Jan 2019 12:09:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B59D218AE for ; Thu, 24 Jan 2019 12:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727898AbfAXMJ5 (ORCPT ); Thu, 24 Jan 2019 07:09:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47990 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfAXMJz (ORCPT ); Thu, 24 Jan 2019 07:09:55 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 74A37796E8; Thu, 24 Jan 2019 12:09:55 +0000 (UTC) Received: from localhost (ovpn-200-36.brq.redhat.com [10.40.200.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id C653A10021B1; Thu, 24 Jan 2019 12:09:50 +0000 (UTC) Date: Thu, 24 Jan 2019 13:09:49 +0100 From: Jesper Dangaard Brouer To: Daniel Borkmann Cc: Maciej Fijalkowski , ast@kernel.org, netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com Subject: Re: [PATCH bpf-next v2 2/8] libbpf: Add a helper for retrieving a prog via index Message-ID: <20190124130949.1bfbbf15@redhat.com> In-Reply-To: <99b1958f-d04c-2b4a-81c1-e9942512df37@iogearbox.net> References: <20190121091041.14666-1-maciejromanfijalkowski@gmail.com> <20190121091041.14666-3-maciejromanfijalkowski@gmail.com> <91d162e0-3d15-c1d8-1e80-8d0a4f561540@iogearbox.net> <20190123144159.000051bd@gmail.com> <20190123152451.7fcdb226@redhat.com> <99b1958f-d04c-2b4a-81c1-e9942512df37@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 24 Jan 2019 12:09:55 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 24 Jan 2019 12:56:36 +0100 Daniel Borkmann wrote: > > Please feel free to deprecate or remove the xdp_redirect_cpu --prognum > > option. I would prefer if this was indeed converted to selecting the > > program based on the name in the _kern.c file, instead of a number. > > Given this is BPF sample code, there is no need to deprecate, lets just > remove --prognum option and add a new one for selection by name. I agree, just remove --prognum option. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer