From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA33BC282C3 for ; Thu, 24 Jan 2019 13:59:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEF2921855 for ; Thu, 24 Jan 2019 13:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbfAXN74 (ORCPT ); Thu, 24 Jan 2019 08:59:56 -0500 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:60900 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727562AbfAXN74 (ORCPT ); Thu, 24 Jan 2019 08:59:56 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1gmfXt-0007j0-Tz; Thu, 24 Jan 2019 14:59:54 +0100 Date: Thu, 24 Jan 2019 14:59:53 +0100 From: Florian Westphal To: wenxu Cc: Pablo Neira Ayuso , Florian Westphal , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, David Ahern Subject: Re: [PATCH v3] netfilter: nft_meta: Add NFT_META_I/OIFKIND meta type Message-ID: <20190124135953.cps24owg5b6aplgl@breakpoint.cc> References: <1547596431-31824-1-git-send-email-wenxu@ucloud.cn> <20190118142430.rsnru4hyrbsodobf@salvia> <20190118143208.42q5ifmidcvtphtt@breakpoint.cc> <20190118143503.3h2tv4fujl4w25mz@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org wenxu wrote: > Hi all, > Are there any other idear for this patch?  Maye should modify  IFNAMSIZ to MODULE_NAME_LEN i think its fine as-is.