From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5742BC282C5 for ; Thu, 24 Jan 2019 15:55:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D05B218B0 for ; Thu, 24 Jan 2019 15:55:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="apeP5hbE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728832AbfAXPzz (ORCPT ); Thu, 24 Jan 2019 10:55:55 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54226 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727755AbfAXPzy (ORCPT ); Thu, 24 Jan 2019 10:55:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6jVJpk/1qN19KLsxgNRgo2iynPDVOgyO/be8wXNXW7E=; b=apeP5hbEK1FtOWtDMT3Ilx7jsg gUcZQYsXygSmdhTiTEhaQQlaedVxufd+925Upd4FzpZITS7o6TA32ttK/YQVv1LfGw4Ztl827JP7Q X+wTD6h08Q6d0SQaSHdKgUyxWDj0TbWd9c9mLkGUhGPiaQaTJu8TwFWX2+3dR9oVlFOA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gmhM2-0001Vg-6k; Thu, 24 Jan 2019 16:55:46 +0100 Date: Thu, 24 Jan 2019 16:55:46 +0100 From: Andrew Lunn To: Yang Wei Cc: netdev@vger.kernel.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yang.wei9@zte.com.cn Subject: Re: [PATCH 1/2] net: fix coding style Message-ID: <20190124155546.GE482@lunn.ch> References: <1548340928-3768-1-git-send-email-albin_yang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548340928-3768-1-git-send-email-albin_yang@163.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 24, 2019 at 10:42:08PM +0800, Yang Wei wrote: Hi Yang Your subject line needs to be a lot more specific. Maybe something like: net: ipv4: ip_input: Fix blank line coding style issues > Fix coding style, remove redundant blank lines. And this is also not accurate. You actually add a blank line. Andrew > > Signed-off-by: Yang Wei > --- > net/ipv4/ip_input.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c > index 51d8efb..cd6b569 100644 > --- a/net/ipv4/ip_input.c > +++ b/net/ipv4/ip_input.c > @@ -429,7 +429,6 @@ static struct sk_buff *ip_rcv_core(struct sk_buff *skb, struct net *net) > if (skb->pkt_type == PACKET_OTHERHOST) > goto drop; > > - > __IP_UPD_PO_STATS(net, IPSTATS_MIB_IN, skb->len); > > skb = skb_share_check(skb, GFP_ATOMIC); > @@ -521,6 +520,7 @@ int ip_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt, > skb = ip_rcv_core(skb, net); > if (skb == NULL) > return NET_RX_DROP; > + > return NF_HOOK(NFPROTO_IPV4, NF_INET_PRE_ROUTING, > net, NULL, skb, dev, NULL, > ip_rcv_finish); > -- > 2.7.4 > >