From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DCEFC282C3 for ; Thu, 24 Jan 2019 19:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C7CD218A2 for ; Thu, 24 Jan 2019 19:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FCra17nb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728926AbfAXTAa (ORCPT ); Thu, 24 Jan 2019 14:00:30 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:34436 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728916AbfAXTA3 (ORCPT ); Thu, 24 Jan 2019 14:00:29 -0500 Received: by mail-pl1-f196.google.com with SMTP id w4so3320475plz.1 for ; Thu, 24 Jan 2019 11:00:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q6UbneBFpTHJNb0L7Yhev5QIcbfaJD4MQpO6+hKgNb8=; b=FCra17nbYYAW2iapwyV4cGnW0zroNXoc4D899kVngWTmsEuZAYvaDBhthZWRJ/Q0b7 a0AoD0sICBK9W6/Po9yTLM7OOC4QQYqnRAilPjyDwrSbhkEeICKvyS/A9HGBG0bq7ive cSbHAYguCMu4rDKcLtwEul8+M1vFe9erGQ1U3cqxZaHv42+NmojdJ5veY4vZFZO5cwO4 8QsTX2msiqRl33cstKrMD+Hgnk6aLFifwPTC4kuMz11hgLWX7gA4GpuDDWM44/4FEsZO dUTRRvHsKTuHalgfHMKNQji+5AN9TiuY8nuInzkmHHE2yv/zoL0B7psL0HkIUWKQSO35 AJUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q6UbneBFpTHJNb0L7Yhev5QIcbfaJD4MQpO6+hKgNb8=; b=SCs9g475CBc2OSZkDSGyAStSj47p1jrDucuq8v2eIArfC1wr4CQXjMZ/mr+C8ZBu6q lHHQLqSg5BBBG6Bkrq6kYRr8ZIaqNo+ue2PDE1NZYboHI/FD8yzpKdP5p9I8NziB33LR s8/sLkVbf8zq7ywBhSjdkqwN47Cop4lO5miwUr6xcelC2JSAbIFk4/sVCK3QSr2NWja7 dXNslZ1hFgHrIuzq4rJh99zEZku4+RfbAArmr87DUCLxeoVeAsVItbpdWHcCZc+b8RDS X6j4yBci5DbloNRYdiJROiEGx3cX16HP3gjPFq0OZ1MbDRKfXkEDG/xDt6Ghi9eqa9jL zcVA== X-Gm-Message-State: AJcUukdygOUpeEchysSsCnIzh9TOEqpg1wrrpT9NM9wDkFmh27XWdYXX ZR3IhAJCv86pNVRyI1JfM+0= X-Google-Smtp-Source: ALg8bN6G5RAN60/URNF51NJTG3rvvFE6agdbutfBvO8Jjdw2Dai/FwSShpEwjLggbVcvuylPY7icIg== X-Received: by 2002:a17:902:f20d:: with SMTP id gn13mr7437411plb.11.1548356429065; Thu, 24 Jan 2019 11:00:29 -0800 (PST) Received: from btopel-mobl.ger.intel.com ([134.134.139.82]) by smtp.gmail.com with ESMTPSA id t90sm31594415pfj.23.2019.01.24.11.00.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 11:00:28 -0800 (PST) From: bjorn.topel@gmail.com To: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org Cc: =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , magnus.karlsson@intel.com, magnus.karlsson@gmail.com Subject: [PATCH bpf-next v2 2/3] xsk: add id to umem Date: Thu, 24 Jan 2019 19:59:38 +0100 Message-Id: <20190124185939.23628-3-bjorn.topel@gmail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190124185939.23628-1-bjorn.topel@gmail.com> References: <20190124185939.23628-1-bjorn.topel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Björn Töpel This commit adds an id to the umem structure. The id uniquely identifies a umem instance, and will be exposed to user-space via the socket monitoring interface. Signed-off-by: Björn Töpel --- include/net/xdp_sock.h | 1 + net/xdp/xdp_umem.c | 13 +++++++++++++ 2 files changed, 14 insertions(+) diff --git a/include/net/xdp_sock.h b/include/net/xdp_sock.h index 13acb9803a6d..61cf7dbb6782 100644 --- a/include/net/xdp_sock.h +++ b/include/net/xdp_sock.h @@ -42,6 +42,7 @@ struct xdp_umem { struct work_struct work; struct page **pgs; u32 npgs; + int id; struct net_device *dev; struct xdp_umem_fq_reuse *fq_reuse; u16 queue_id; diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c index a264cf2accd0..eabdb0f59031 100644 --- a/net/xdp/xdp_umem.c +++ b/net/xdp/xdp_umem.c @@ -13,12 +13,15 @@ #include #include #include +#include #include "xdp_umem.h" #include "xsk_queue.h" #define XDP_UMEM_MIN_CHUNK_SIZE 2048 +static DEFINE_IDA(umem_ida); + void xdp_add_sk_umem(struct xdp_umem *umem, struct xdp_sock *xs) { unsigned long flags; @@ -183,6 +186,8 @@ static void xdp_umem_release(struct xdp_umem *umem) xdp_umem_clear_dev(umem); + ida_simple_remove(&umem_ida, umem->id); + if (umem->fq) { xskq_destroy(umem->fq); umem->fq = NULL; @@ -389,8 +394,16 @@ struct xdp_umem *xdp_umem_create(struct xdp_umem_reg *mr) if (!umem) return ERR_PTR(-ENOMEM); + err = ida_simple_get(&umem_ida, 0, 0, GFP_KERNEL); + if (err < 0) { + kfree(umem); + return ERR_PTR(err); + } + umem->id = err; + err = xdp_umem_reg(umem, mr); if (err) { + ida_simple_remove(&umem_ida, umem->id); kfree(umem); return ERR_PTR(err); } -- 2.19.1