From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310A4C282C5 for ; Thu, 24 Jan 2019 18:27:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 005B6218A6 for ; Thu, 24 Jan 2019 18:27:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i/LLtuAd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbfAXS1n (ORCPT ); Thu, 24 Jan 2019 13:27:43 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:44144 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbfAXS1m (ORCPT ); Thu, 24 Jan 2019 13:27:42 -0500 Received: by mail-lj1-f193.google.com with SMTP id k19-v6so6104655lji.11 for ; Thu, 24 Jan 2019 10:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HzhwpAIS95UhipIBsb7xchV6WU9w7B37cC75iWEP8jY=; b=i/LLtuAdZgYWGO3Nm0IhJ1XaEkC/j37h73A0kNpL77KEe+tN9dF1726ryQXZwrxhV6 8fdyftXhVkr3cSwAMdZpTZ0rt+KXdCNg6+OPj/u77whstSEGIIV4PJa1C5W95HW8s5EY bVPbKZ5+OVXzzPFEvNpvknKW9q7y3ZUeVhqokRJCZMXGBFKo2MAKsnUSoLl46/+MXFlu 4Iqma6khHhJ3X5Jte7F4nqfuV7saYlKXNDxbdb5FEPIVKWBOMIl3B+8P1gz1Nz82oX/l 2u2nfjVkU2vSmcW8vlMe/FmsYRMQmiLP/DW/f+lRwiOGFshAoUKK/MjExWkqK09pV6Q/ /92A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HzhwpAIS95UhipIBsb7xchV6WU9w7B37cC75iWEP8jY=; b=phYiaae3pXwktGYSPMlAgPYXwojLoH5kutEqBWrb7QcAEa3pIIx00TE7M/kntehNEe 5bgBoUZONn3mbCqkEhPfmZ98jnn5mAd5Re19s86UqvqvCyNcG9LJChpdvhZfvG/9RvS1 xvaQdQFz6TVCdhdhLg81f0k7LhNVrggZgDVFVl6SV0qEqH6eFVto0uEQEuIXvuYXbgbT LrMaRbjgtidycWDVwV9AFnppkr3pOod3x1C7n8AG9RPlDHOr7HkqwKpaNgmS4ihRB98U Ca9olJT3RTOr6W/kYg1ov4NblloHRq44XRmiq/S8zs57t4Pm+uOqSgo+/V75GkbAKTOc Gd+g== X-Gm-Message-State: AJcUukcys7aKwats9wRRc30j/9nVU+THRq2tWfOzavPZR4pNLUk9t6Br mLbj0ZQ0sxbTCTk1Va3lE3bqf1NJ X-Google-Smtp-Source: ALg8bN4lWhoBvPPsSfVH9SLUXK3xqc3LlZOQdKGg8fpmHaZ6vP1h2hoUmZxzHSbX3hI/CPDlHJ0RgA== X-Received: by 2002:a2e:9256:: with SMTP id v22-v6mr5857344ljg.178.1548354460466; Thu, 24 Jan 2019 10:27:40 -0800 (PST) Received: from maciek-lenovo (host-185-93-94-63.ip-point.pl. [185.93.94.63]) by smtp.gmail.com with ESMTPSA id r1-v6sm1137561ljb.64.2019.01.24.10.27.39 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 24 Jan 2019 10:27:40 -0800 (PST) Date: Thu, 24 Jan 2019 19:27:35 +0100 From: Maciej =?UTF-8?B?RmlqYcWCa293c2tp?= To: Jesper Dangaard Brouer , Daniel Borkmann Cc: ast@kernel.org, netdev@vger.kernel.org, jakub.kicinski@netronome.com Subject: Re: [PATCH bpf-next v2 2/8] libbpf: Add a helper for retrieving a prog via index Message-ID: <20190124192735.76aaa463@maciek-lenovo> In-Reply-To: <20190124130949.1bfbbf15@redhat.com> References: <20190121091041.14666-1-maciejromanfijalkowski@gmail.com> <20190121091041.14666-3-maciejromanfijalkowski@gmail.com> <91d162e0-3d15-c1d8-1e80-8d0a4f561540@iogearbox.net> <20190123144159.000051bd@gmail.com> <20190123152451.7fcdb226@redhat.com> <99b1958f-d04c-2b4a-81c1-e9942512df37@iogearbox.net> <20190124130949.1bfbbf15@redhat.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 24 Jan 2019 13:09:49 +0100 Jesper Dangaard Brouer wrote: > On Thu, 24 Jan 2019 12:56:36 +0100 > Daniel Borkmann wrote: > > > > Please feel free to deprecate or remove the xdp_redirect_cpu --prognum > > > option. I would prefer if this was indeed converted to selecting the > > > program based on the name in the _kern.c file, instead of a number. > > > > Given this is BPF sample code, there is no need to deprecate, lets just > > remove --prognum option and add a new one for selection by name. > > I agree, just remove --prognum option. > Actually we can convert it to --progname and use it for providing the section name of program to be loaded. On Wed, 23 Jan 2019 15:11:09 +0100 Daniel Borkmann wrote: > > can live with this. In case of typo and program being not found it would be > > good to print out the section names to choose from in usage(). > > Agree, might be nice as well via libbpf. Would it be acceptable to print them from within libbpf? Something as trivial as: void bpf_object__print_type_sections(struct bpf_object *obj, enum bpf_prog_type type) { struct bpf_program *prog; bpf_object__for_each_program(prog, obj) { if (bpf_program__is_type(prog, type)) pr_info("section %s\n", prog->section_name); } } Or do we want to add a accessor for section_name and go through programs in application?