From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9551CC282C3 for ; Thu, 24 Jan 2019 20:30:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54E942184C for ; Thu, 24 Jan 2019 20:30:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="VX7dnrKe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727513AbfAXUaX (ORCPT ); Thu, 24 Jan 2019 15:30:23 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:45214 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbfAXUaW (ORCPT ); Thu, 24 Jan 2019 15:30:22 -0500 Received: by mail-pf1-f193.google.com with SMTP id g62so3550074pfd.12 for ; Thu, 24 Jan 2019 12:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=6LqceLFc7LWEOBa9nr/Nn0tOr3DcbKCUSLCwuQelhFM=; b=VX7dnrKe6xvLy6ZkDDKw1MuTu56WQyzbbgwxp/SYxlODA+504UXwnZANodLqEWb0zn X8Bi53LI6NeM4DtPSAED9mrHs96rEG3oJbcC8144ToVpAULdLs7NzYTx4zO//uUilX9d uXL5GcnJpr8e6TC6j1knJCW0XupF7NQi/f9JGCNWII7IDPYkBeu/KUkAU6ZOOBSSYCJB jsX6zJ38/OzBjDLDqzyT/h9KP4m4U4MJWv6cJ4QVk3KUpPT9Nmd97xHuFpuQUz8QNrdg AH0iWju66NbSK+uitn4JMwiPQLGix+ML/uIfvCqxWH6uNOSA4YY9A5ybf2gA32hyosyr 2KpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6LqceLFc7LWEOBa9nr/Nn0tOr3DcbKCUSLCwuQelhFM=; b=B9J6VcoUDw7vNxz4XeyxJe1VHG6/LL0YpYtWS5m9/uJIrgM4laaMb+xmpWvf0hXXgz t6NAsJtjGgtxnHgt0129rerA7PdsAbPnnaOVDmmCuuOWpNNBHl8dlSEJLjZl0x/xVuwj WejSD5XJDAonle27F932SNWLsAc5wRrbGCfuU4kH8Tef5fyeEaGp839U5Zxv0d2Xn2Q9 6oCWmlglYlxyhvxzHP+hooS5irN6ZYuff2m7uN+OEZYMDRGe/43JKdPyf8YHfrFvYYRT uQkR+uFuZs0FgpL9ogh7rv+frx8TFYFpyrDxxkJO8A7m/pAlzABGb0wNjDAUxmFVIJKu s1Sw== X-Gm-Message-State: AJcUukcZ+NPAsGzJIhQ0UuG7nXvArY8Bb7gTPVfTF/J1l6pijsfN2Bpj HkqnwlZ/GTtAlcXRmsI7xI1Owjtdl+1ktA== X-Google-Smtp-Source: ALg8bN4BtXhkecUq6WACVPqf16Kz3AXx0jp1fra33blKPMaFIOSI3nlCzdPddfLGYqtGEuIDZApcnw== X-Received: by 2002:a62:5b44:: with SMTP id p65mr7896515pfb.47.1548361821503; Thu, 24 Jan 2019 12:30:21 -0800 (PST) Received: from shemminger-XPS-13-9360.canterbury.ac.nz ([202.36.179.100]) by smtp.gmail.com with ESMTPSA id d129sm46462903pfc.31.2019.01.24.12.30.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 12:30:20 -0800 (PST) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger Subject: [PATCH iproute2-next 1/2] tc: replace print_string with fprintf for error messages Date: Fri, 25 Jan 2019 09:30:13 +1300 Message-Id: <20190124203014.7450-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Any error output should go to standard error. Signed-off-by: Stephen Hemminger --- tc/f_matchall.c | 2 +- tc/m_connmark.c | 2 +- tc/m_csum.c | 2 +- tc/m_gact.c | 2 +- tc/m_ife.c | 2 +- tc/m_mirred.c | 2 +- tc/m_nat.c | 2 +- tc/m_sample.c | 2 +- tc/m_skbedit.c | 2 +- tc/m_vlan.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tc/f_matchall.c b/tc/f_matchall.c index 03dd51de1ace..59f452c5361e 100644 --- a/tc/f_matchall.c +++ b/tc/f_matchall.c @@ -146,7 +146,7 @@ static int matchall_print_opt(struct filter_util *qu, FILE *f, if (tb[TCA_MATCHALL_PCNT]) { if (RTA_PAYLOAD(tb[TCA_MATCHALL_PCNT]) < sizeof(*pf)) { - print_string(PRINT_FP, NULL, "Broken perf counters\n", NULL); + fprintf(stderr, "Performance counter size mismatch\n"); return -1; } pf = RTA_DATA(tb[TCA_MATCHALL_PCNT]); diff --git a/tc/m_connmark.c b/tc/m_connmark.c index 45e2d05f1a91..34d80b1a27c0 100644 --- a/tc/m_connmark.c +++ b/tc/m_connmark.c @@ -114,7 +114,7 @@ static int print_connmark(struct action_util *au, FILE *f, struct rtattr *arg) parse_rtattr_nested(tb, TCA_CONNMARK_MAX, arg); if (tb[TCA_CONNMARK_PARMS] == NULL) { - print_string(PRINT_FP, NULL, "%s", "[NULL connmark parameters]"); + fprintf(stderr, "NULL connmark parameters\n"); return -1; } diff --git a/tc/m_csum.c b/tc/m_csum.c index 752269d1d020..450f2b557b44 100644 --- a/tc/m_csum.c +++ b/tc/m_csum.c @@ -172,7 +172,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr *arg) parse_rtattr_nested(tb, TCA_CSUM_MAX, arg); if (tb[TCA_CSUM_PARMS] == NULL) { - fprintf(f, "[NULL csum parameters]"); + fprintf(stderr, "missing csum parameters\n"); return -1; } sel = RTA_DATA(tb[TCA_CSUM_PARMS]); diff --git a/tc/m_gact.c b/tc/m_gact.c index a0a3c33d23da..342927bc2ed7 100644 --- a/tc/m_gact.c +++ b/tc/m_gact.c @@ -174,7 +174,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr *arg) parse_rtattr_nested(tb, TCA_GACT_MAX, arg); if (tb[TCA_GACT_PARMS] == NULL) { - print_string(PRINT_FP, NULL, "%s", "[NULL gact parameters]"); + fprintf(stderr, "[NULL gact parameters]\n"); return -1; } p = RTA_DATA(tb[TCA_GACT_PARMS]); diff --git a/tc/m_ife.c b/tc/m_ife.c index 2bf9f2047b46..b754cfc3a03a 100644 --- a/tc/m_ife.c +++ b/tc/m_ife.c @@ -234,7 +234,7 @@ static int print_ife(struct action_util *au, FILE *f, struct rtattr *arg) parse_rtattr_nested(tb, TCA_IFE_MAX, arg); if (tb[TCA_IFE_PARMS] == NULL) { - print_string(PRINT_FP, NULL, "%s", "[NULL ife parameters]"); + fprintf(stderr, "[NULL ife parameters]\n"); return -1; } p = RTA_DATA(tb[TCA_IFE_PARMS]); diff --git a/tc/m_mirred.c b/tc/m_mirred.c index c7f7318b8413..fb4cab5fb9eb 100644 --- a/tc/m_mirred.c +++ b/tc/m_mirred.c @@ -286,7 +286,7 @@ print_mirred(struct action_util *au, FILE *f, struct rtattr *arg) parse_rtattr_nested(tb, TCA_MIRRED_MAX, arg); if (tb[TCA_MIRRED_PARMS] == NULL) { - print_string(PRINT_FP, NULL, "%s", "[NULL mirred parameters]"); + fprintf(stderr, "mirred parameters missing\n"); return -1; } p = RTA_DATA(tb[TCA_MIRRED_PARMS]); diff --git a/tc/m_nat.c b/tc/m_nat.c index ee0b7520a605..4cd255299ccb 100644 --- a/tc/m_nat.c +++ b/tc/m_nat.c @@ -152,7 +152,7 @@ print_nat(struct action_util *au, FILE * f, struct rtattr *arg) parse_rtattr_nested(tb, TCA_NAT_MAX, arg); if (tb[TCA_NAT_PARMS] == NULL) { - print_string(PRINT_FP, NULL, "%s", "[NULL nat parameters]"); + fprintf(stderr, "[NULL nat parameters]\n"); return -1; } sel = RTA_DATA(tb[TCA_NAT_PARMS]); diff --git a/tc/m_sample.c b/tc/m_sample.c index 39a99246a8ea..2af098ecba90 100644 --- a/tc/m_sample.c +++ b/tc/m_sample.c @@ -149,7 +149,7 @@ static int print_sample(struct action_util *au, FILE *f, struct rtattr *arg) if (!tb[TCA_SAMPLE_PARMS] || !tb[TCA_SAMPLE_RATE] || !tb[TCA_SAMPLE_PSAMPLE_GROUP]) { - print_string(PRINT_FP, NULL, "%s", "[NULL sample parameters]"); + fprintf(stderr, "[NULL sample parameters]\n"); return -1; } p = RTA_DATA(tb[TCA_SAMPLE_PARMS]); diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c index b6b839f8ef6c..ee0cd987fa3a 100644 --- a/tc/m_skbedit.c +++ b/tc/m_skbedit.c @@ -186,7 +186,7 @@ static int print_skbedit(struct action_util *au, FILE *f, struct rtattr *arg) parse_rtattr_nested(tb, TCA_SKBEDIT_MAX, arg); if (tb[TCA_SKBEDIT_PARMS] == NULL) { - print_string(PRINT_FP, NULL, "%s", "[NULL skbedit parameters]"); + fprintf(stderr, "[NULL skbedit parameters]\n"); return -1; } p = RTA_DATA(tb[TCA_SKBEDIT_PARMS]); diff --git a/tc/m_vlan.c b/tc/m_vlan.c index 412f6aa1000e..f58bbf0a0320 100644 --- a/tc/m_vlan.c +++ b/tc/m_vlan.c @@ -188,7 +188,7 @@ static int print_vlan(struct action_util *au, FILE *f, struct rtattr *arg) parse_rtattr_nested(tb, TCA_VLAN_MAX, arg); if (!tb[TCA_VLAN_PARMS]) { - print_string(PRINT_FP, NULL, "%s", "[NULL vlan parameters]"); + fprintf(stderr, "[NULL vlan parameters]\n"); return -1; } parm = RTA_DATA(tb[TCA_VLAN_PARMS]); -- 2.17.1