From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C57C282C3 for ; Sat, 26 Jan 2019 05:37:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D73B6218A6 for ; Sat, 26 Jan 2019 05:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727662AbfAZFhi (ORCPT ); Sat, 26 Jan 2019 00:37:38 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:50616 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbfAZFhi (ORCPT ); Sat, 26 Jan 2019 00:37:38 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AFDFA108AE10D; Fri, 25 Jan 2019 21:37:37 -0800 (PST) Date: Fri, 25 Jan 2019 21:37:37 -0800 (PST) Message-Id: <20190125.213737.270826932318222086.davem@davemloft.net> To: posk@google.com Cc: netdev@vger.kernel.org, posk.devel@gmail.com Subject: Re: [PATCH net-next 0/4] net: IP defrag: use rbtrees in IPv6 defragmentation From: David Miller In-Reply-To: <20190122180253.128336-1-posk@google.com> References: <20190122180253.128336-1-posk@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 25 Jan 2019 21:37:37 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Peter Oskolkov Date: Tue, 22 Jan 2019 10:02:49 -0800 > Currently, IPv6 defragmentation code drops non-last fragments that > are smaller than 1280 bytes: see > commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags smaller than min mtu") > > This behavior is not specified in IPv6 RFCs and appears to break compatibility > with some IPv6 implementations, as reported here: > https://www.spinics.net/lists/netdev/msg543846.html > > This patchset contains four patches: > - patch 1 moves rbtree-related code from IPv4 to files shared b/w > IPv4/IPv6 > - patch 2 changes IPv6 defragmenation code to use rbtrees for defrag > queue > - patch 3 changes nf_conntrack IPv6 defragmentation code to use rbtrees > - patch 4 changes ip_defrag selftest to test changes made in the > previous three patches. > > Along the way, the 1280-byte restrictions are removed. > > I plan to introduce similar changes to 6lowpan defragmentation code > once I figure out how to test it. Series applied, thanks.