From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Maciej Fijalkowski <maciejromanfijalkowski@gmail.com>
Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org,
jakub.kicinski@netronome.com, brouer@redhat.com
Subject: Re: [PATCH bpf-next v3 4/7] samples/bpf: Extend RLIMIT_MEMLOCK for xdp_{sample_pkts, router_ipv4}
Date: Fri, 25 Jan 2019 09:32:11 +0100 [thread overview]
Message-ID: <20190125093211.724f6d5c@redhat.com> (raw)
In-Reply-To: <20190124214747.6986-5-maciejromanfijalkowski@gmail.com>
On Thu, 24 Jan 2019 22:47:44 +0100
Maciej Fijalkowski <maciejromanfijalkowski@gmail.com> wrote:
> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>
> There is a common problem with xdp samples that happens when user wants
> to run a particular sample and some bpf program is already loaded. The
> default 64kb RLIMIT_MEMLOCK resource limit will cause a following error
> (assuming that xdp sample that is failing was converted to libbpf
> usage):
>
> libbpf: Error in bpf_object__probe_name():Operation not permitted(1).
> Couldn't load basic 'r0 = 0' BPF program.
> libbpf: failed to load object './xdp_sample_pkts_kern.o'
>
> Fix it in xdp_sample_pkts and xdp_router_ipv4 by setting RLIMIT_MEMLOCK
> to RLIM_INFINITY.
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> samples/bpf/xdp_router_ipv4_user.c | 7 +++++++
> samples/bpf/xdp_sample_pkts_user.c | 7 +++++++
> 2 files changed, 14 insertions(+)
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-01-25 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 21:47 [PATCH bpf-next v3 0/7] xdp: Avoid unloading xdp prog not attached by sample Maciej Fijalkowski
2019-01-24 21:47 ` [PATCH bpf-next v3 1/7] libbpf: Add a helper for retrieving a map fd for a given name Maciej Fijalkowski
2019-01-24 21:47 ` [PATCH bpf-next v3 2/7] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Maciej Fijalkowski
2019-01-24 21:47 ` [PATCH bpf-next v3 3/7] samples/bpf: Convert XDP samples to libbpf usage Maciej Fijalkowski
2019-01-25 8:30 ` Jesper Dangaard Brouer
2019-01-25 17:53 ` Maciej Fijałkowski
2019-01-24 21:47 ` [PATCH bpf-next v3 4/7] samples/bpf: Extend RLIMIT_MEMLOCK for xdp_{sample_pkts, router_ipv4} Maciej Fijalkowski
2019-01-25 8:32 ` Jesper Dangaard Brouer [this message]
2019-01-24 21:47 ` [PATCH bpf-next v3 5/7] samples/bpf: Add a "force" flag to XDP samples Maciej Fijalkowski
2019-01-25 8:38 ` Jesper Dangaard Brouer
2019-01-25 17:52 ` Maciej Fijałkowski
2019-01-24 21:47 ` [PATCH bpf-next v3 6/7] libbpf: Add a support for getting xdp prog id on ifindex Maciej Fijalkowski
2019-01-24 21:47 ` [PATCH bpf-next v3 7/7] samples/bpf: Check the prog id before exiting Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125093211.724f6d5c@redhat.com \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).