From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Carlo Caione <ccaione@baylibre.com>,
f.fainelli@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: at803x: Use helpers to access MMD PHY registers
Date: Fri, 25 Jan 2019 19:51:32 +0100 [thread overview]
Message-ID: <20190125185132.GF22211@lunn.ch> (raw)
In-Reply-To: <a7f5531b-902b-2849-02a5-a4ec8660e06d@gmail.com>
On Fri, Jan 25, 2019 at 07:11:28PM +0100, Heiner Kallweit wrote:
> On 25.01.2019 16:00, Andrew Lunn wrote:
> > On Fri, Jan 25, 2019 at 12:35:10PM +0000, Carlo Caione wrote:
> >> Libphy provides a standard set of helpers to access the MMD PHY
> >> registers. Use those instead of relying on custom driver-specific
> >> functions.
> >
> > Hi Carlo
> >
> > Maybe deja vu, but i thought a similar patch went by recently?
> >
> Andrew, maybe you mean this one?
>
> 9b420eff9fcf ("net: phy: micrel: use phy_read_mmd and phy_write_mmd")
Yes, probably that one.
Might be worth grepping of 0xd, 0xe, 0x0d, 0x0e, 13, 14, and see if
there are any more instances in PHY drivers.
Andrew
next prev parent reply other threads:[~2019-01-25 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 12:35 [PATCH] net: phy: at803x: Use helpers to access MMD PHY registers Carlo Caione
2019-01-25 15:00 ` Andrew Lunn
2019-01-25 15:03 ` Carlo Caione
2019-01-25 18:11 ` Heiner Kallweit
2019-01-25 18:51 ` Andrew Lunn [this message]
2019-01-25 18:40 ` Florian Fainelli
2019-01-27 21:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125185132.GF22211@lunn.ch \
--to=andrew@lunn.ch \
--cc=ccaione@baylibre.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).