From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D19C282C3 for ; Sat, 26 Jan 2019 06:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A0D8218A6 for ; Sat, 26 Jan 2019 06:17:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="LTaeO2oy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727290AbfAZGRe (ORCPT ); Sat, 26 Jan 2019 01:17:34 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:46118 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbfAZGRd (ORCPT ); Sat, 26 Jan 2019 01:17:33 -0500 Received: by mail-pl1-f194.google.com with SMTP id t13so5510745ply.13 for ; Fri, 25 Jan 2019 22:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=y6BtvpNhs8yiQMDD0CCFZhVsXIl/+neVXeta/REFHmw=; b=LTaeO2oys0bGFhc+RnP2+2A/PFGipuVyuVvoqGCVZ0knWlFAWmfIb2dnqVV2BnpX+E Cb1jmuYXqWXh4lZ/SEmipnTXN3wNuRl7xJ+2s+WALJTy2wsLF33oraIoVYSd26Nnacmp gwUX2CY1yRW30xpEF9pmAH5+/t9574S/XC3RIA/Nj7JXnPblsBalv0UYUEyQE0PeRyGf ihqQxsox0jrOIYADXpJNw42tVV1Cc3qy53Cx3Xu9cbkLLYuKZG9RtgmLTgqrfN9Ztg/S lLYgOgb8/+WeXQS9QRzRP5QPAqRbMlngJe6bgvia4nq0Vugl8nQQJ4BCx4WoZMWaDDyV ZkVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=y6BtvpNhs8yiQMDD0CCFZhVsXIl/+neVXeta/REFHmw=; b=orynbbxH/3V5k0gVSuWcf22qGXnMT/yN4TP0tjrvhb+jtaCzrqlyreN+iYb2pJ//9u QC+e64arpsLoyDofBUOSdniD4ass3uuPvu73Us/+I8qfYNxTTzoNb96nROifFFiREyW/ l3N/NRxdBjEWvLxAaj3afrEkDy2AE036YZr/h3A4nF39dIwl6VRcgq9E17jE7vsSCs4C bycjw3GKpVbIDyzjT2XLeCwYFaK/O52Ht9CP4cQqgFb4jrn6X7E/nTHbCGr1tF5Dw5Rl TPxAy4lkfvsb2sS9eMxTai/0hG9ZLLg/gi7Kfs0pzf0NEbgNNo3fy/TXJb5IUj2gn+D0 k3fw== X-Gm-Message-State: AJcUukcXQyi7+FtppJ5+DmjNA7tDa+7VoR7zzSQiMaBuWpm9Bf8UU1a/ q9LVHesqc9mtsUiKdik6zQzpNw== X-Google-Smtp-Source: ALg8bN6j9UJgQgej1cwGZcSe0luHT01EM0CSmrfjpELo1tOOUafYrw3C5+FILqRKP1ssXxqXjvIkrA== X-Received: by 2002:a17:902:a710:: with SMTP id w16mr13728682plq.95.1548483452992; Fri, 25 Jan 2019 22:17:32 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id p2sm33376293pfb.28.2019.01.25.22.17.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Jan 2019 22:17:32 -0800 (PST) Date: Fri, 25 Jan 2019 22:17:28 -0800 From: Jakub Kicinski To: Alexei Starovoitov Cc: daniel@iogearbox.net, oss-drivers@netronome.com, netdev@vger.kernel.org Subject: Re: [PATCH bpf-next v2 0/3] selftests: bpf: break up test_verifier Message-ID: <20190125221728.3990b9d1@cakuba.netronome.com> In-Reply-To: <20190126055528.r3xvfgtazdf44ab6@ast-mbp.dhcp.thefacebook.com> References: <20190125232444.30172-1-jakub.kicinski@netronome.com> <20190126055528.r3xvfgtazdf44ab6@ast-mbp.dhcp.thefacebook.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 25 Jan 2019 21:55:30 -0800, Alexei Starovoitov wrote: > On Fri, Jan 25, 2019 at 03:24:41PM -0800, Jakub Kicinski wrote: > > Hi! > > > > The tools/testing/selftests/bpf/test_verifier.c file is > > way too large, and since most people add their at the > > end of the list it's very prone to conflicts. > > > > Break it up in the simplest possible way - slice the > > array up into smaller C files and include them in the > > right spot. > > > > Tested: > > $ make -C tools/testing/selftests/bpf/ > > $ cd tools/testing/selftests/bpf/ ; make > > > > v2: > > > > The indentation is reduced further as discussed and lines folded. > > The conversion was scripted, and double checked by hand. > > Looks great to me, but even first patch conflicts too much to apply. > Please respin one more time. I could have sworn when I pulled bpf-next this morning Jiong's patches were in it ;) I'll rebase/repost tomorrow morning.