From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2843AC282C9 for ; Sat, 26 Jan 2019 18:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4E7F218A6 for ; Sat, 26 Jan 2019 18:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548526642; bh=QyYos8J22xGttwEkSsloPr9b53jWflyVXasitIlxMLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jTOsJu42vZFztJ2N/l/JDbBLCf7S+eO0bTIEItChsmns/WFGvOfrsnAUwQGzmq2C6 GvhtD12wT4DweWP+05fwTzmfdtTLW2Mh/EM29/1RaXq4ujd2Cf7FGG8Hiw2vAMAwV/ hUi8s5rB3VTNqVyg0Uq23udZp9S6wE5C8SzUop1s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726305AbfAZSRU (ORCPT ); Sat, 26 Jan 2019 13:17:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:38134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfAZSRU (ORCPT ); Sat, 26 Jan 2019 13:17:20 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF53621872; Sat, 26 Jan 2019 18:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548526640; bh=QyYos8J22xGttwEkSsloPr9b53jWflyVXasitIlxMLY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wi1XmEa4BwZcIODG12zarwAdlOr3xwf56lnmYPqY5Z7ZAPHh+wodpjxa4hv+QV1Bw 9KaNGZ47ivGeGQ30WNKF+XQ8oOQT6XDkQ4lsUmDC4Fze8Y1YVkHRrTEadC0AL0z7vc gbyLcB880nsdk6UHjo/1DPrSsEmDO+zoNbd33S4c= Date: Sat, 26 Jan 2019 13:17:18 -0500 From: Sasha Levin To: Oliver Hartkopp Cc: davem@davemloft.net, netdev@vger.kernel.org, stable@vger.kernel.org, linux-can@vger.kernel.org, lifeasageek@gmail.com, threeearcat@gmail.com, syzkaller@googlegroups.com, nautsch2@gmail.com, Kyungtae Kim , Marc Kleine-Budde Subject: Re: [PATCH] [stable pre-4.8] can: bcm: check timer values before ktime conversion Message-ID: <20190126181718.GE30183@sasha-vm> References: <20190124090842.2938-1-socketcan@hartkopp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190124090842.2938-1-socketcan@hartkopp.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 24, 2019 at 10:08:42AM +0100, Oliver Hartkopp wrote: >Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() >when the conversion into ktime multiplies the given value with NSEC_PER_USEC >(1000). > >Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 > >Add a check for the given tv_usec, so that the value stays below one second. >Additionally limit the tv_sec value to a reasonable value for CAN related >use-cases of 400 days and ensure all values to be positive. > >This patch is the pre-4.8 version of upstream commit 93171ba6f1deffd8 I can't find this commit id upstream, there's nothing with the same subject name, nor does this code exist upstream. What's going on? -- Thanks, Sasha