From: David Miller <davem@redhat.com>
To: rmk+kernel@armlinux.org.uk
Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] Revert "net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x"
Date: Sun, 27 Jan 2019 23:00:24 -0800 (PST) [thread overview]
Message-ID: <20190127.230024.1757311902628384187.davem@redhat.com> (raw)
In-Reply-To: <E1gnAtB-0002Cz-Tr@rmk-PC.armlinux.org.uk>
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Fri, 25 Jan 2019 23:27:57 +0000
> This reverts commit 6623c0fba10ef45b64ca213ad5dec926f37fa9a0.
>
> The original diagnosis was incorrect: it appears that the NIC had
> PHY polling mode enabled, which meant that it overwrote the PHYs
> advertisement register during negotiation.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
The code in the 'net' tree has the linkmode_clear_bit() etc. changes
that were done to this driver, so the pause variable is not there
and the pause bits are adjusted using that helper.
Please respin this against current sources so that it actually
applies.
Thank you.
prev parent reply other threads:[~2019-01-28 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 23:27 [PATCH] Revert "net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x" Russell King
2019-01-26 15:58 ` Andrew Lunn
2019-01-26 16:23 ` Russell King - ARM Linux admin
2019-01-28 7:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127.230024.1757311902628384187.davem@redhat.com \
--to=davem@redhat.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).