From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69835C282C8 for ; Mon, 28 Jan 2019 07:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 422AD217D7 for ; Mon, 28 Jan 2019 07:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbfA1HEI (ORCPT ); Mon, 28 Jan 2019 02:04:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfA1HEI (ORCPT ); Mon, 28 Jan 2019 02:04:08 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 316A6C049DC1; Mon, 28 Jan 2019 07:04:07 +0000 (UTC) Received: from localhost (ovpn-112-14.rdu2.redhat.com [10.10.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8829C83BEF; Mon, 28 Jan 2019 07:04:04 +0000 (UTC) Date: Sun, 27 Jan 2019 23:04:03 -0800 (PST) Message-Id: <20190127.230403.636736583040998189.davem@redhat.com> To: khoroshilov@ispras.ru Cc: david.wu@rock-chips.com, peppe.cavallaro@st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix error handling in rk_gmac_powerup() From: David Miller In-Reply-To: <1548532137-15618-1-git-send-email-khoroshilov@ispras.ru> References: <1548532137-15618-1-git-send-email-khoroshilov@ispras.ru> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 28 Jan 2019 07:04:08 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Alexey Khoroshilov Date: Sat, 26 Jan 2019 22:48:57 +0300 > If phy_power_on() fails in rk_gmac_powerup(), clocks are left enabled. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Applied, thank you.