From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94928C282C8 for ; Mon, 28 Jan 2019 07:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F03620882 for ; Mon, 28 Jan 2019 07:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbfA1HU2 (ORCPT ); Mon, 28 Jan 2019 02:20:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39704 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbfA1HU1 (ORCPT ); Mon, 28 Jan 2019 02:20:27 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C445081DE3; Mon, 28 Jan 2019 07:20:27 +0000 (UTC) Received: from localhost (ovpn-112-14.rdu2.redhat.com [10.10.112.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D25610640F5; Mon, 28 Jan 2019 07:20:26 +0000 (UTC) Date: Sun, 27 Jan 2019 23:20:25 -0800 (PST) Message-Id: <20190127.232025.1249730889680261599.davem@redhat.com> To: andrew@lunn.ch Cc: vivien.didelot@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix serdes irq setup going recursive From: David Miller In-Reply-To: <20190127214800.4202-1-andrew@lunn.ch> References: <20190127214800.4202-1-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 28 Jan 2019 07:20:27 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Lunn Date: Sun, 27 Jan 2019 22:48:00 +0100 > Duec to a typo, mv88e6390_serdes_irq_setup() calls itself, rather than > mv88e6390x_serdes_irq_setup(). It then blows the stack, and shortly > after the machine blows up. > > Fixes: 2defda1f4b91 ("net: dsa: mv88e6xxx: Add support for SERDES on ports 2-8 for 6390X") > Signed-off-by: Andrew Lunn Applied, thanks Andrew.