From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F22C282C0 for ; Sun, 27 Jan 2019 07:51:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2155214C6 for ; Sun, 27 Jan 2019 07:51:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="MuMd+LW5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726647AbfA0HvQ (ORCPT ); Sun, 27 Jan 2019 02:51:16 -0500 Received: from mail-eopbgr80073.outbound.protection.outlook.com ([40.107.8.73]:55360 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726280AbfA0HvQ (ORCPT ); Sun, 27 Jan 2019 02:51:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GIb0SBui48Wq1/7mSGHZk/ayPSLHeU5ftAN2FdaEeQU=; b=MuMd+LW5iLBRR2+Da1j3N7iSXYB7KthuOm2CYhUXcIucNgREhh2RiCj1e0M8+XXNAHiRUHL2E2AWtPogCX/UgMy6W0++UTvYlyf/EzMfHLgERmQ7fNF3jOnSJasNZVHhYyvsUPiA3LQFGKMSZWmpOCLhs58v5X+KL93zL7xY4tQ= Received: from DB6PR0501MB2694.eurprd05.prod.outlook.com (10.172.226.9) by DB6PR0501MB2471.eurprd05.prod.outlook.com (10.168.73.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.17; Sun, 27 Jan 2019 07:51:11 +0000 Received: from DB6PR0501MB2694.eurprd05.prod.outlook.com ([fe80::ed9e:f27:4597:6db2]) by DB6PR0501MB2694.eurprd05.prod.outlook.com ([fe80::ed9e:f27:4597:6db2%10]) with mapi id 15.20.1558.023; Sun, 27 Jan 2019 07:51:11 +0000 From: Leon Romanovsky To: Saeed Mahameed CC: Saeed Mahameed , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Jason Gunthorpe Subject: Re: [PATCH mlx5-next 0/4] mlx5 next misc updates Thread-Topic: [PATCH mlx5-next 0/4] mlx5 next misc updates Thread-Index: AQHUr46doHAiqwvoPUqPqRHa8q36EaW+Yh+AgAHwkwCAAnhSgA== Date: Sun, 27 Jan 2019 07:51:11 +0000 Message-ID: <20190127075109.GY3604@mtr-leonro.mtl.com> References: <20190119003313.16711-1-saeedm@mellanox.com> <20190124123041.GS3604@mtr-leonro.mtl.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-clientproxiedby: AM6P192CA0057.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::34) To DB6PR0501MB2694.eurprd05.prod.outlook.com (2603:10a6:4:82::9) authentication-results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR0501MB2471;6:bWO5+zAPxMKpM2Hv0jPYUVF1adEK7YVWq6w1KuMgzjvYvKiQpICVNtS6EfiCGjHYao2c9zXpox3CdE8ydJscLw8Ux0hZ0NOIQdneBzUxDewHCBowRy7+DDqVs13AcFBT/kzqTJzBmU1RL8qRbK4NByQaHhdIpNzjRNBpUUdByG570D6blSaVQgc1BxwvSSbVBDQyNDlj9es5th9YjiOx6xPp6UwCNKLIftfU0+WJNgvh629KRTQF7gg235vEWw4KKE1Dfe/eeoXR6uNE5lGMA4gVeQWf8AecL0Vktgr/nuHY83BhBP5Zm8lGWkkgOXdgLTPOhbsuny8oFzXw2qalmCuBAtOFkIGGiQJlS6hx0XGs6kFTdqRywQOFX1CLWncV6qz4pPHE9PMTxTpaHjHdoy0B1VoBFvxHyuAbd334TSO+0pMlpQLoZt3PBEl9oDxTvplq4fMzuL+DwDgTDNLHEQ==;5:CboDz6oveVLSznrThOOwFxjN5AhT9O7hWHlU5UbpkBdfT30bfy+91KM7P8xipepiLmW0NOUUCeSY2m/OOcUPzrYX4UK7fzytyyrSamzSkgIM+0bprU0fk5MDHqNTQLnSHZBLhPgNkT8JPT67Pc0yQeqSlehsKN3mN/NcQ4GRrEq5V5Ue/JwgToIbRd4LjoutMs/D3iqwpW8fun0PKVqQYw==;7:5F/0DlVOM7MagnTOaGfSWlSifcwG3cZNVUkRInEJbFIyG9ipI0CycFLUsAPjxehO87ZvYRx5Y/7m37+BnUaBJm6IBAGkU3H4lUIyk7xp8MiuscZM/PgzBrktVaDEsCeVpxpzDvnBgshQ8xz19oEOTg== x-ms-office365-filtering-correlation-id: 8b46d973-1305-4360-3d0a-08d6842c347e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(49563074)(7193020);SRVR:DB6PR0501MB2471; x-ms-traffictypediagnostic: DB6PR0501MB2471: x-microsoft-antispam-prvs: x-forefront-prvs: 0930AAFAD9 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(136003)(346002)(39850400004)(366004)(376002)(53754006)(189003)(199004)(33656002)(14454004)(486006)(478600001)(446003)(9686003)(6512007)(54906003)(316002)(476003)(11346002)(25786009)(99936001)(68736007)(6436002)(33896004)(186003)(102836004)(386003)(6506007)(53546011)(66066001)(256004)(14444005)(6486002)(229853002)(52116002)(76176011)(26005)(99286004)(2906002)(8936002)(3846002)(6116002)(81156014)(8676002)(15650500001)(86362001)(97736004)(305945005)(53936002)(71190400001)(105586002)(71200400001)(450100002)(81166006)(6246003)(107886003)(6862004)(7736002)(1076003)(106356001)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0501MB2471;H:DB6PR0501MB2694.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: bHJU6D2DtI5AYmdpzMq8AV7ieClKToSdD9/ZOs2FJoo3rZXLvvqEDqK+ibHTPx6OvBdq9qJBW/+U7ZVmbHT832XW57eb86+Iz26m07HHOJeBa4eHQlSKKtUhQJ+/xBSljaiyF08QbXFCw3v5Z7jjkkTO2mJaDY1QN2uLJrbEWWWdC/UQpITPZXv25JjfB1LMaKGguxJFnjgBhsXTMEdXjqjwrEtmmCyuqOOrxBuhrGzpWCIkLjTSvF09fz1eDu3HbG0V/LkX0DofRoxGd19iBYOxCEVhZZ6GUoQjpKkgeMFplPEFrOz2ejoPwUi7NFrQvyvfsidPtwsLRWRKoN7q0cf/G3wio1r+uKa76jO+5ZZ8nZPrKYUhg2RFrar5xbe+Z8DdQ7/oIT5KCdcrkjDh3DPZZ+xE+FbVUN0b/2+huls= Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l8yJEXo8J9fv7OFY" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b46d973-1305-4360-3d0a-08d6842c347e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2019 07:51:11.1297 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2471 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --l8yJEXo8J9fv7OFY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 25, 2019 at 10:08:00AM -0800, Saeed Mahameed wrote: > On Thu, Jan 24, 2019 at 4:30 AM Leon Romanovsky wrote: > > > > On Fri, Jan 18, 2019 at 04:33:09PM -0800, Saeed Mahameed wrote: > > > Hi all, > > > > > > This series includes updates to mlx5-next shared branch. > > > > > > 1) from Jason, improve mlx5_cmd_exec_cb async API to be safer > > > 2) from Maxim Mikityanskiy, cleanups for mlx5_write64 doorbell API > > > 3) from Michael Guralnik, Add pci AtomicOps request > > > > > > Thanks, > > > Saeed. > > > > > > --- > > > > > > Jason Gunthorpe (1): > > > net/mlx5: Make mlx5_cmd_exec_cb() a safe API > > > > > > Michael Guralnik (1): > > > net/mlx5: Add pci AtomicOps request > > > > Those two were applied to mlx5-next branch. > > > > ce4eee5340a9 (mlx5-next) net/mlx5: Add pci AtomicOps request > > e355477ed9e4 net/mlx5: Make mlx5_cmd_exec_cb() a safe API > > > > > Maxim Mikityanskiy (2): > > > net/mlx5: Remove unused MLX5_*_DOORBELL_LOCK macros > > > net/mlx5: Remove spinlock support from mlx5_write64 > > > > Those two needs extra work, > > What extra work ? You got two comments for area you are touching: 1. Replace _rww writes to something else. 2. Protect with spinlock 32-bits writes instead of ignoring it. Both of those changes will touch the same 2-4 lines and there is very little benefit in creating more than one-two patches just for that. Thanks > > > > > Thanks > > > > > > > > -- > > > 2.20.1 > > > --l8yJEXo8J9fv7OFY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcTWLtAAoJEORje4g2clin2EIQAIlsDxTcUaul4OAHMflt9Ofk A98hv5+GK1djH/DB1PYDvegHEiRAUKKhbuI0AXSQvFgANqO0lNF96y+3zqidXVRV K5hX4cBc19ymqdzxqqnCuD2wTisb1r1BEGy12YIqAUpPF2s5jchJuYlFEUqVDfmm PaZXWKqQmhH/vPZHeZKTK75sct8Pjva/lsHBbwPAMxybERP7TC52carmn4lh2vZj sQCl4c1xBu15gq8Zjxk+87NkPbxykvRqq09Kz3OreY0Gkia4H/VlDzl7lGXq9po4 pCapW57aOpU7wPi7QII9Lpjq41XhgrEkGYlJDGeyBOs5q5REuRVnPSpzVABcbuS2 sRXiniNWHhvF87nT4Rv7mC3Wx7OTXixcBBcVCFYUXOKJ3NhTX3ZYubRoQVVBp/p/ iyKMgvGWmzK+84g1my1GprPq9cDMbeh1jfO5wg7+PgxHQg10eRKKCtAbMb+uETcn YqAN7B3fqMZkPvMPyt4R2JpDIOnQ1QsRG9KEt7mfX0xygVGbhd77w4tEXjL/d78x 4Xb4xN7cL1cdyfdoAqJsav7345s3Tkyb/ljRF0jH+g16oUqn90tjq0MiYwqjvZqd WEGrwGY+BvjMzdyNifHJSPbyLYMmBSuu+DMrJJ+icHn26JL4tR1Z5JDhcJjqx0RC Ni4CvGCzaFXLxflgCdn4 =Zro/ -----END PGP SIGNATURE----- --l8yJEXo8J9fv7OFY--