From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 116A4C282C0 for ; Sun, 27 Jan 2019 08:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D54A5214C6 for ; Sun, 27 Jan 2019 08:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548577802; bh=BocPIBgGGPG91H8hUMU5h03s1DECefaWG9/tKzS+Aso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dbvX99Y6RftUNzVV3HoYJArX5U30EtODKA6x1TYKUYUCdjx3/d3b0Yxj2MhwYiNqW E89kak4hd2zqw3Zp4G5uLNIZYGD1Wb2bQUmSl+mELU9LhF45i73oSI0+zuDD9byaXW mxYKUOcHVaWLISDg86zYlCNe0k6G0TI8WLu2ujto= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfA0IaC (ORCPT ); Sun, 27 Jan 2019 03:30:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:54240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726604AbfA0IaB (ORCPT ); Sun, 27 Jan 2019 03:30:01 -0500 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 155F0214C6; Sun, 27 Jan 2019 08:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548577800; bh=BocPIBgGGPG91H8hUMU5h03s1DECefaWG9/tKzS+Aso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mqVI0undamR/DFd+jF83HDP2xafiaCNjZtWoicgYPpO4sHQpzDGBSmS7MBqlMXjqP dclkk1fPQSDo2wqhBjPp7EBCLeCy3BnaykVSDLUrVGYUUz51nTWVCvU9iO+xm7dXrK nmIiyeNwkNfs726wK7p2Gs/noxy9nGxUC4sO1lbo= Date: Sun, 27 Jan 2019 10:29:57 +0200 From: Leon Romanovsky To: David Ahern Cc: netdev , RDMA mailing list , Stephen Hemminger Subject: Re: [PATCH iproute2-next 05/19] rdma: Move resource PD logic to separate file Message-ID: <20190127082957.GB3604@mtr-leonro.mtl.com> References: <20190122183125.15920-1-leon@kernel.org> <20190122183125.15920-6-leon@kernel.org> <0ad0319f-194c-d574-e7f7-eca71c7a008a@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s9pXJW6w71JX4l3T" Content-Disposition: inline In-Reply-To: <0ad0319f-194c-d574-e7f7-eca71c7a008a@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --s9pXJW6w71JX4l3T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 25, 2019 at 10:19:22AM -0700, David Ahern wrote: > On 1/22/19 11:31 AM, Leon Romanovsky wrote: > > +static const > > +struct filters pd_valid_filters[MAX_NUMBER_OF_FILTERS] = { > > + { .name = "dev", .is_number = false }, > > + { .name = "users", .is_number = true }, > > + { .name = "pid", .is_number = true }, > > + { .name = "ctxn", .is_number = true }, > > + { .name = "pdn", .is_number = true }, > > + { .name = "ctxn", .is_number = true } > > +}; > > These should not be in a header file. Looks like you have done this in > other patches as well. This is the outcome of how we build command line with single struct *rd, see res_show(). While I refactored the code, I saw your comment is coming, but decided to proceed anyway to make this series a little bit sane. I'll definitely continue to refactor it, but for now, there is a need to see valid_filters structure in RES_FUNC() macro. Thanks --s9pXJW6w71JX4l3T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcTWwFAAoJEORje4g2clin7ZMP/jIC35Z1RGmjXUbCcAOq2vh4 9qaGWt3azDRRIASX/6u308c1lLBra1R8kTnlKwW3GC7hmGGH1mt1I56Rq+gnebt4 oxXS+Z7MrzqK0P61tFz+zf5xORPvDm8+8ht81mI/sfW3tFBdBMNBaPMjD+Zwm6VN bHxNb17ijJz+X0iGlkfXd0Ih6kNPaB1N8jKJHCLmMT+jFCy4rVTSDfGCqi/XTdrD fvPekuEO0jtcXsGw79HCt/wYcuHHHvXSW+7P40hA1dfeifiJLj/9r91a/ma4rAT8 Hp2/fXmBaJq/rB9DUQQPHVKbZFFKO/53dOtmISv8hDSyUCCO9WIEngO+CzX0GDio eVpM3ad7XDXbPGDIpNP+DkBa522ISVVf1yUDGo5sbBh3Np9eR4o814IOKUaLNqmK wdfFon2Xj36t4BMkfd05E5vS8kwHmEMUPEDl4gNrwkvDjSrorHc4G0ni5Fuuu6aF kD2AX2KexZ/Hc2Ko33s0bvi1s45bDvVXn6SheYD/4pBp7R7+VTExos8yutKvT1Tr vZuT2rUQTSOxhvTxxi45erDei+Cz95TDBwmdludwESHLA8WYxe3sAfQjOVMKJ5r9 q4Hpf17yfcEhu3Ji7jzTUszIE/AmcAnHdhdLwR/sU7A65oCJ3XFdd+5tr3/lY4CF eHY1QC0KGzy5BCSh8f9e =a+vJ -----END PGP SIGNATURE----- --s9pXJW6w71JX4l3T--