From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE0D7C282CA for ; Sun, 27 Jan 2019 18:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FDCA21473 for ; Sun, 27 Jan 2019 18:33:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="bRpvEndj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbfA0Sde (ORCPT ); Sun, 27 Jan 2019 13:33:34 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43770 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbfA0Sde (ORCPT ); Sun, 27 Jan 2019 13:33:34 -0500 Received: by mail-pg1-f196.google.com with SMTP id v28so6253917pgk.10 for ; Sun, 27 Jan 2019 10:33:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=ftdAm5jJsTneMA1b+Bd5O/Ar28JcOxxPSpHfXZqm7fU=; b=bRpvEndjwqcig/v6baMijT6LWvE3Ks9m1YPzdzDc92jASLRnDmnimoUKMOsDPgiCGy g9+eKMg1D1K35FIGKHTgt4SZAlHAbi+U299dkY9NBp+XSO/vs2lE8GuGaxApwHTjF37q U5eadPLf/7gyb2fWqb498zS/GcBYwqGeCvxCxUVvnoU4OXBMSZYys3sCEov7YPv+s0hS 7/QulGUj+cO0dYXQCPDgFsywm/UAKXYKwChgHPS+jAdYDHww4ZwsDtNG6+xYksko9XPc 4RQzj9wV7e81S+MyWgOjZRqVmYQtapFAjTopB0ps9rB+lP1Qf9dE8G1jQO1I4rZ7LBNq zk6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=ftdAm5jJsTneMA1b+Bd5O/Ar28JcOxxPSpHfXZqm7fU=; b=Hi5zLk0jh+vM9euI1QXiPhhluyltI+v/NVpc0sy6/HX/caAWkTJn1Jrbr0EEHHm2wH emYqVE2pxM3kbDDpRlB7he1VYilDiHisn0Ik2+xtd31rNki0f2KPKvJel8v3NSlhqMd7 ejUsMic2A2+IL8c9sHzi08Xjwl+DtPsqXjfYnRshDn+8ivWFZ4i0D56JXiFdDkef6AOz 0vMY69yifuFwqlIzKB53yaV53ENPuigyR4uhTbBU4pkvTzHV0p6sfCrhT6jStVs4+tuZ 7Y8pypKcxI9ahvLVxknXEz2zrf9cZadItEU14UMdtpsraGeZnXfK48u9FFJm4Dar7yFF hEAg== X-Gm-Message-State: AJcUukcZGeIVwq+HMF0N07XwZ1ofo4on/HlyiPSSQ65S9TZcMjCMbryf RMHA87c1D9PXHtJi3dr5ix+0/yotYGY= X-Google-Smtp-Source: ALg8bN4HLJ4Af5ZHkXx34YkcUucOvVFbfgXnuDtmasq6NnrvySSLGuIsLxKlnbsDfsnFTs/T0LTKcQ== X-Received: by 2002:a62:c28e:: with SMTP id w14mr19053434pfk.115.1548614013108; Sun, 27 Jan 2019 10:33:33 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([2601:646:8e00:727e::2]) by smtp.gmail.com with ESMTPSA id 4sm38937147pfq.10.2019.01.27.10.33.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Jan 2019 10:33:32 -0800 (PST) Date: Sun, 27 Jan 2019 10:33:28 -0800 From: Jakub Kicinski To: Alexei Starovoitov Cc: daniel@iogearbox.net, oss-drivers@netronome.com, netdev@vger.kernel.org Subject: Re: [PATCH bpf-next v2 0/3] selftests: bpf: break up test_verifier Message-ID: <20190127103328.266e363e@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190126062120.pzb4jw2rzv6o5jp3@ast-mbp.dhcp.thefacebook.com> References: <20190125232444.30172-1-jakub.kicinski@netronome.com> <20190126055528.r3xvfgtazdf44ab6@ast-mbp.dhcp.thefacebook.com> <20190125221728.3990b9d1@cakuba.netronome.com> <20190126062120.pzb4jw2rzv6o5jp3@ast-mbp.dhcp.thefacebook.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 25 Jan 2019 22:21:22 -0800, Alexei Starovoitov wrote: > On Fri, Jan 25, 2019 at 10:17:28PM -0800, Jakub Kicinski wrote: > > On Fri, 25 Jan 2019 21:55:30 -0800, Alexei Starovoitov wrote: > > > On Fri, Jan 25, 2019 at 03:24:41PM -0800, Jakub Kicinski wrote: > > > > Hi! > > > > > > > > The tools/testing/selftests/bpf/test_verifier.c file is > > > > way too large, and since most people add their at the > > > > end of the list it's very prone to conflicts. > > > > > > > > Break it up in the simplest possible way - slice the > > > > array up into smaller C files and include them in the > > > > right spot. > > > > > > > > Tested: > > > > $ make -C tools/testing/selftests/bpf/ > > > > $ cd tools/testing/selftests/bpf/ ; make > > > > > > > > v2: > > > > > > > > The indentation is reduced further as discussed and lines folded. > > > > The conversion was scripted, and double checked by hand. > > > > > > Looks great to me, but even first patch conflicts too much to apply. > > > Please respin one more time. > > > > I could have sworn when I pulled bpf-next this morning Jiong's patches > > were in it ;) I'll rebase/repost tomorrow morning. > > They were ;) until they were pulled off. > Any order is fine. Looks like v2 just applies cleanly again, should I repost?