From: Andrew Lunn <andrew@lunn.ch>
To: Yang Wei <albin_yang@163.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, yang.wei9@zte.com.cn
Subject: Re: [PATCH V2] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq
Date: Sun, 27 Jan 2019 17:34:19 +0100 [thread overview]
Message-ID: <20190127163419.GA28088@lunn.ch> (raw)
In-Reply-To: <1548604388-4087-1-git-send-email-albin_yang@163.com>
On Sun, Jan 27, 2019 at 11:53:08PM +0800, Yang Wei wrote:
> dev_consume_skb_irq() should be called in i596_interrupt() when
> xmit done. It makes drop profiles more friendly.
>
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
> ---
Hi Yang
It is normal to include here, under the ---, what has changed since
the previous version of the patch.
Please also read
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
Your patches don't have the correct subject.
Thanks
Andrew
next prev parent reply other threads:[~2019-01-27 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 15:53 [PATCH V2] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq Yang Wei
2019-01-27 16:34 ` Andrew Lunn [this message]
[not found] ` <201901280950423897221@zte.com.cn>
2019-01-28 2:03 ` [PATCH V2] net: i825xx: replace dev_kfree_skb_irq bydev_consume_skb_irq Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127163419.GA28088@lunn.ch \
--to=andrew@lunn.ch \
--cc=albin_yang@163.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yang.wei9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).