From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54301C282CA for ; Sun, 27 Jan 2019 16:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3B202146E for ; Sun, 27 Jan 2019 16:34:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="eIjui5We" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726879AbfA0QeZ (ORCPT ); Sun, 27 Jan 2019 11:34:25 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:56686 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbfA0QeZ (ORCPT ); Sun, 27 Jan 2019 11:34:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W2AUt+louqERcgJUMzFN0cJmWlgZItKmy6l56vSVOtc=; b=eIjui5WeFAmtZdySVZ5M0iy5kU WIdSBXZFv94a4aBquuKUnGkwBsthq7j9l9sGiVlTqhUbScoeOX95l9v7af4+6becVzL+zWD8RdjFl ppk91h/lLaWHhzb54GayLhuJIkrr5a6xN65p/KkplaMdREmUlxaMW/7ByJhWwbVk3F90=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gnnNz-0007Vx-7d; Sun, 27 Jan 2019 17:34:19 +0100 Date: Sun, 27 Jan 2019 17:34:19 +0100 From: Andrew Lunn To: Yang Wei Cc: netdev@vger.kernel.org, davem@davemloft.net, yang.wei9@zte.com.cn Subject: Re: [PATCH V2] net: i825xx: replace dev_kfree_skb_irq by dev_consume_skb_irq Message-ID: <20190127163419.GA28088@lunn.ch> References: <1548604388-4087-1-git-send-email-albin_yang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548604388-4087-1-git-send-email-albin_yang@163.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jan 27, 2019 at 11:53:08PM +0800, Yang Wei wrote: > dev_consume_skb_irq() should be called in i596_interrupt() when > xmit done. It makes drop profiles more friendly. > > Signed-off-by: Yang Wei > --- Hi Yang It is normal to include here, under the ---, what has changed since the previous version of the patch. Please also read https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html Your patches don't have the correct subject. Thanks Andrew