From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D909AC282CC for ; Sun, 27 Jan 2019 19:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3A6D20881 for ; Sun, 27 Jan 2019 19:34:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="FndEqesL"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GrnWeBVz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbfA0TeQ (ORCPT ); Sun, 27 Jan 2019 14:34:16 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:51861 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726695AbfA0TeQ (ORCPT ); Sun, 27 Jan 2019 14:34:16 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 2FE07FD30; Sun, 27 Jan 2019 14:34:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 27 Jan 2019 14:34:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=dLXwk0KyqIqZEExk3v1BJ/vtxeD Fa5OsiOJDsISB7QU=; b=FndEqesL2WouIobd4Q/mAZ40wCw24Mb8LJhb3HNr5L+ 42e0b9wFMAnWMGAhukNImS6jt4EGSCB9WcnbZ7EUsq6TOGs2nHDSBoHQ0AcA3tT0 /HQFqaXDVu6gV7QdHho/MoZCENpSKSvDY4G6WAVZK5R0stliIvkYL0ok6Gw7Mkvd U7f1OkCP3qP4vDgqyikW+YLBu6Dkp+GxMpY4dNqDQEHc8hDlc6rw+HgcqJSs+QC8 yv9Lpn6X7hx/6qsvVRU9R01Ow1S8V2jxHFRjIvZhIcVSdhc49w8PPhqnhbGwN/KM OUYn03mmwYGnTZh2k/JL3/z4Yl6p5W6OJU9au/43tfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dLXwk0 KyqIqZEExk3v1BJ/vtxeDFa5OsiOJDsISB7QU=; b=GrnWeBVzSeB7sJVzbDo2Vi R641mp5r41212b2lwkUT8E4HJiaakb/VIdhUCOsJMHsurJ9lWd8nlD+x52m1e2Ms Hbe/ULHrT4AIp0TURcs7dnRYM2YScakncTP+qY+QShn1DWvgcAS4/FhZzNQGBoae 1DHoWAb5DbvBn1Sapl4DpU2MRGZgOKPbt+vgpAKg7xqQHX3ssTNcQLe+pC4PMfJS w2r4dWRnHhH9NR+trNUlJ8m347vO6G2Z4jFeivMkG2GziKZgrdDoapKmWTmZO7J2 Ba/x7EhTvA0m1tIrgjyLHKMoNKNUt1edtI/sGD5Yg/VeSyW28Z799G9E8mTds28Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrieekgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogfuphgrmhfkphculdeftd dtmdenucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefi rhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucffohhmrghinhepkhgvrh hnvghlrdhorhhgpdhmrghrtgdrihhnfhhonecukfhppeekfedrkeeirdekledruddtjeen ucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhmnecuvehluh hsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 6A84910087; Sun, 27 Jan 2019 14:34:13 -0500 (EST) Date: Sun, 27 Jan 2019 20:34:11 +0100 From: Greg KH To: Oliver Hartkopp Cc: Sasha Levin , davem@davemloft.net, netdev@vger.kernel.org, stable@vger.kernel.org, linux-can@vger.kernel.org, lifeasageek@gmail.com, threeearcat@gmail.com, syzkaller@googlegroups.com, nautsch2@gmail.com, Kyungtae Kim , Marc Kleine-Budde Subject: Re: [PATCH] [stable pre-4.8] can: bcm: check timer values before ktime conversion Message-ID: <20190127193411.GB25051@kroah.com> References: <20190124090842.2938-1-socketcan@hartkopp.net> <20190126181718.GE30183@sasha-vm> <8a72ffa5-dac5-6de8-f01e-dfbb98b1f024@hartkopp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a72ffa5-dac5-6de8-f01e-dfbb98b1f024@hartkopp.net> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jan 27, 2019 at 07:22:38PM +0100, Oliver Hartkopp wrote: > Hi Sasha, > > On 26.01.19 19:17, Sasha Levin wrote: > > On Thu, Jan 24, 2019 at 10:08:42AM +0100, Oliver Hartkopp wrote: > > > Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() > > > when the conversion into ktime multiplies the given value with > > > NSEC_PER_USEC > > > (1000). > > > > > > Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 > > > > > > Add a check for the given tv_usec, so that the value stays below one > > > second. > > > Additionally limit the tv_sec value to a reasonable value for CAN related > > > use-cases of 400 days and ensure all values to be positive. > > > > > > This patch is the pre-4.8 version of upstream commit 93171ba6f1deffd8 > > > > I can't find this commit id upstream, there's nothing with the same > > subject name, nor does this code exist upstream. What's going on? > > Here we are (pulled by Linus some minutes ago): > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93171ba6f1deffd82f381d36cb13177872d023f6 > > Can you go with this pre-4.8 version now? Let me get the others into the newer kernels first please :) Should be a day or so at most... thanks, greg k-h