From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 290B7C282CA for ; Sun, 27 Jan 2019 19:35:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4F2120879 for ; Sun, 27 Jan 2019 19:35:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="bIYselZ0"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="knR710Qv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbfA0TfG (ORCPT ); Sun, 27 Jan 2019 14:35:06 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:34917 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726695AbfA0TfG (ORCPT ); Sun, 27 Jan 2019 14:35:06 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 86A2F5FA4; Sun, 27 Jan 2019 14:35:05 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sun, 27 Jan 2019 14:35:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=jR0VVT8Ghs5uc0hJ8MAbL4nCh2d WzEpqRGOGPo9S0sE=; b=bIYselZ0yPRapLS5J7w0dG1vhTjuL9MN8SRYKq6S1B+ pXUrzmN+uzc7TjvMYOqBIyOi7h/iy4vDTmXlTFSRISIYP7yvLfkQsARGRPV58j/l o9TepzjNJ41wjSCpJeOO0nMhodVjr80Okg4U6V8ZubPNTsuU8hFjdyCZTsb7PXmE 6RKKrMov4K68C0xO3FyQBh2+ry8kirkuI44AZ9WSobNyrNENR7cYxkDuJrXox0dI jPiJZthnxER0w/dUJfzZRuFRTFHtx0Z3KD3YTh03BhoQ0MlGQslIiaHAxX0iNvBU zmsPsVe4WDIv4/zqcv/gEGHBpq0DWk1q8okuxPZVj2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=jR0VVT 8Ghs5uc0hJ8MAbL4nCh2dWzEpqRGOGPo9S0sE=; b=knR710Qvh9KXdENeyFQS2x xKWpBaIE90U/iUB8kHk6xKU3uxibBzqcr4nU3KjZvc8pbHXheP2XbnUcFqzvTk3C RbyvPIZlRdQ/L8mgI3HsAcuuf38uZU51AMVe9Sxs+vBBq0UHk7Sl7IhNlPXmmtE5 DOQ/y7mjKeSG+AjLK6Z4n5uZfCeHbgwzVFiZVH4XYahatTqBYbbswUKeps3Who8l IbZexc/NJH272gFotdQoyq9jtx9zB9fZxoFNG0uk0gYcogyYZll/iOCcXRuTxomf ety/SLbGiuBad48MmuZ8Tii7UzpzA6FwYYM0zJ1mwsHZRalYGpvEbW7k2jgdqC8g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrieekgdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogfuphgrmhfkphculdeftd dtmdenucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefi rhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrke elrddutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtgho mhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id C8727100BB; Sun, 27 Jan 2019 14:35:04 -0500 (EST) Date: Sun, 27 Jan 2019 20:35:03 +0100 From: Greg KH To: "Yavuz, Tuba" Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" Subject: Re: Error in the hso driver Message-ID: <20190127193503.GC25051@kroah.com> References: <1548614320825.86428@ece.ufl.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548614320825.86428@ece.ufl.edu> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jan 27, 2019 at 06:38:41PM +0000, Yavuz, Tuba wrote: > Hello, > > > On an error path inside the hso_create_net_device function of the hso driver (drivers/net/usb/hso), hso_free_net_device gets called. This causes a negative reference count in the net device if register_netdev has not been called yet as hso_free_net_device calls unregister_netdev regardless. I think the driver should distinguish these cases and call unregister_netdev only if register_netdev has been called. > > > Detected on v4.14-rc2 but I believe the problem still exists in the newer versions. Can you send a patch to solve this issue? That's the best way to handle it as you get the proper credit and we can understand exactly what you are trying to show here. thanks, greg k-h