From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F932C282CA for ; Sun, 27 Jan 2019 19:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 195FA20989 for ; Sun, 27 Jan 2019 19:53:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="T+PA9+Bv"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kRmTNe+x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbfA0TxU (ORCPT ); Sun, 27 Jan 2019 14:53:20 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:44017 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726840AbfA0TxT (ORCPT ); Sun, 27 Jan 2019 14:53:19 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 06D19F214; Sun, 27 Jan 2019 14:53:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 27 Jan 2019 14:53:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=dYioU5K6aILHlEOxxZqHLSAoq1w wvkO5kojiBzS0ixU=; b=T+PA9+BvYZa3n783laPBN4GxXzxtysEG2RKMItYcfx6 jWsxwnPkfhTFVWY5j5bQNf/pm6uvbVL8Rvi9zUc5c3atThN7gNSsBD44AsqliiOh CYxg+TFiP/I6audZ52bRtRbJR5Td5ooFc1aQUFNknDzRqmhG032uipzYFD8b6Hlr k7KO6WJZxNYxOVR25i180Mx01nOtcU8KnWV8pWwo3HRz2gcBzE0cTl0VY12l0krt cXHSJ2B3QX8qZ2ARS3BRsL01nEReGzqWbRW0Y16z60efbb81D3uE4hquqLollxbo Cn+VSRPwf0N2nNRAewmrwtTbzBKZjGvCU7c/gW6CpLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dYioU5 K6aILHlEOxxZqHLSAoq1wwvkO5kojiBzS0ixU=; b=kRmTNe+xWcM7ARJsmFGvVD UqECKlzWS93jZ7Kh/8CBK2axxAUrzIJzzZdc9myxYe9PxrLg8A25LmB6/vqekj6k cMGvpFXU9AtY8uJsBgnwMonOsMD2w9PHIaDDE2P0Rqi42eyA38HIXQ67BaHxS7wg ysuG3CX/32meog0QmDZXmXo7eiXYjrWkqJzPkjnOw87vl6ygckxbm2GZTh73uwMy awEjcCpLoypovtBhMa/B44sXQ4AOtyzrMKwHKQnYL/RTiShNHpHekTEnOUFI0LoZ 9kMMZpcflMHBZ2fbbuiMKAONcCYsG5/KbDaqsH4RHqtcxpT3569vXNoFZvywdRsw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrieekgddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogfuphgrmhfkphculdeftd dtmdenucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefi rhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrke elrddutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtgho mhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id CA388E432B; Sun, 27 Jan 2019 14:53:17 -0500 (EST) Date: Sun, 27 Jan 2019 20:53:16 +0100 From: Greg KH To: "Yavuz, Tuba" Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" Subject: Re: Error in the hso driver Message-ID: <20190127195316.GA27263@kroah.com> References: <1548614320825.86428@ece.ufl.edu> <20190127193503.GC25051@kroah.com> <1548618592071.43193@ece.ufl.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548618592071.43193@ece.ufl.edu> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jan 27, 2019 at 07:49:52PM +0000, Yavuz, Tuba wrote: > Here is a proposed patch: > > --- drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500 > +++ drivers/net/usb/hso.c 2019-01-27 14:47:43.592683629 -0500 > @@ -2377,7 +2377,7 @@ static void hso_free_net_device(struct h > > remove_net_device(hso_net->parent); > > - if (hso_net->net) > + if (hso_net->net && hso_net->net->reg_state == NETREG_REGISTERED) > unregister_netdev(hso_net->net); > > /* start freeing */ > > Can you resend it in a format that it can be applied? Documentation/SubmittingPatches should have all of the needed details. thanks, greg k-h