From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E2AC282CA for ; Sun, 27 Jan 2019 23:07:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDB1D2133D for ; Sun, 27 Jan 2019 23:07:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726566AbfA0XHc (ORCPT ); Sun, 27 Jan 2019 18:07:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:37018 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726302AbfA0XHc (ORCPT ); Sun, 27 Jan 2019 18:07:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3CDD9ACE3; Sun, 27 Jan 2019 23:07:31 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 7FF69E012B; Mon, 28 Jan 2019 00:07:30 +0100 (CET) Date: Mon, 28 Jan 2019 00:07:30 +0100 From: Michal Kubecek To: Jakub Kicinski Cc: netdev@vger.kernel.org, Vasundhara Volam , davem@davemloft.net, michael.chan@broadcom.com, jiri@mellanox.com Subject: Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port Message-ID: <20190127230730.GF24651@unicorn.suse.cz> References: <1547795385-12354-1-git-send-email-vasundhara-v.volam@broadcom.com> <20190118143319.GG26670@unicorn.suse.cz> <20190122141842.26908b27@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122141842.26908b27@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 22, 2019 at 02:18:42PM -0800, Jakub Kicinski wrote: > > I think reusing new netlink ethtool with a special flag would be a nice, > complete solution. We could also address link settings this way (which > are a pre-requisite for WoL). > > I have no strong preference on the mechanism, but for ease of setting > as well as dumping would it be workable to use a nesting, like this: > > Run time settings: > [ETHTOOL_SETTINGS_BLA] > [ETHTOOL_BLA_VAL_1] > [ETHTOOL_BLA_VAL_2] > ... > > Persistent: > [ETHTOOL_PERSISTENT] > [ETHTOOL_SETTINGS_BLA] > [ETHTOOL_BLA_VAL_1] > [ETHTOOL_BLA_VAL_2] > > IOW encapsulate settings into a "persistent" attribute? > > How does that look to you, Michal? It's certainly one of the options worth considering. What I like is that this approach would not require knowing (or rather guessing) which attributes are going to allow persistent settings in the future. Michal