From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6917C282CF for ; Mon, 28 Jan 2019 19:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72C662148E for ; Mon, 28 Jan 2019 19:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727052AbfA1TW6 (ORCPT ); Mon, 28 Jan 2019 14:22:58 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48740 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728259AbfA1TW6 (ORCPT ); Mon, 28 Jan 2019 14:22:58 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8582C14EFB255; Mon, 28 Jan 2019 11:22:57 -0800 (PST) Date: Mon, 28 Jan 2019 11:22:56 -0800 (PST) Message-Id: <20190128.112256.1993605129492088954.davem@davemloft.net> To: johannes@sipsolutions.net Cc: netdev@vger.kernel.org, viro@zeniv.linux.org.uk, robert@ocallahan.org Subject: Re: [PATCH net 0/4] various compat ioctl fixes From: David Miller In-Reply-To: <20190125214320.17685-1-johannes@sipsolutions.net> References: <20190125214320.17685-1-johannes@sipsolutions.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Jan 2019 11:22:57 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Johannes Berg Date: Fri, 25 Jan 2019 22:43:16 +0100 > Back a long time ago, I already fixed a few of these by passing > the size of the struct ifreq to do_sock_ioctl(). However, Robert > found more cases, and now it won't be as simple because we'd have > to pass that down all the way to e.g. bond_do_ioctl() which isn't > really feasible. > > Therefore, restore the old code. > > While looking at why SIOCGIFNAME was broken, I realized that Al > had removed that case - which had been handled in an explicit > separate function - as well, and looking through his work at the > time I saw that bond ioctls were also affected by the erroneous > removal. > > I've restored SIOCGIFNAME and bond ioctls by going through the > (now renamed) dev_ifsioc() instead of reintroducing their own > helper functions, which I hope is correct but have only tested > with SIOCGIFNAME. I see some back and forth between you and Al, where do we stand at this point? >From what I can see this looks like probably the simplest way to fix this in net and -stable currently. Please let me know. Thanks.