* [PATCH net-next] net: nci: remove set-but-not-used variable 'status'
@ 2019-01-29 6:40 YueHaibing
2019-01-29 7:04 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-01-29 6:40 UTC (permalink / raw)
To: davem, sameo; +Cc: linux-kernel, netdev, linux-wireless, YueHaibing
gcc warning this:
net/nfc/nci/hci.c:373:5:
warning: variable 'status' set but not used [-Wunused-but-set-variable]
It not used since commit d8cd37ed2fc8 ("NFC: nci: Fix improper
management of HCI return code"), so can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/nfc/nci/hci.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/net/nfc/nci/hci.c b/net/nfc/nci/hci.c
index ddfc52a..4debba8 100644
--- a/net/nfc/nci/hci.c
+++ b/net/nfc/nci/hci.c
@@ -370,17 +370,11 @@ static void nci_hci_resp_received(struct nci_dev *ndev, u8 pipe,
u8 result, struct sk_buff *skb)
{
struct nci_conn_info *conn_info;
- u8 status = result;
conn_info = ndev->hci_dev->conn_info;
- if (!conn_info) {
- status = NCI_STATUS_REJECTED;
- goto exit;
- }
-
- conn_info->rx_skb = skb;
+ if (conn_info)
+ conn_info->rx_skb = skb;
-exit:
nci_req_complete(ndev, NCI_STATUS_OK);
}
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: nci: remove set-but-not-used variable 'status'
2019-01-29 6:40 [PATCH net-next] net: nci: remove set-but-not-used variable 'status' YueHaibing
@ 2019-01-29 7:04 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-29 7:04 UTC (permalink / raw)
To: yuehaibing; +Cc: sameo, linux-kernel, netdev, linux-wireless
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 29 Jan 2019 14:40:28 +0800
> gcc warning this:
> net/nfc/nci/hci.c:373:5:
> warning: variable 'status' set but not used [-Wunused-but-set-variable]
>
> It not used since commit d8cd37ed2fc8 ("NFC: nci: Fix improper
> management of HCI return code"), so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
I'll let the wireless/nfc folks pick this up.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-29 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-29 6:40 [PATCH net-next] net: nci: remove set-but-not-used variable 'status' YueHaibing
2019-01-29 7:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).