From: David Miller <davem@davemloft.net>
To: davejwatson@fb.com
Cc: netdev@vger.kernel.org, vakul.garg@nxp.com, borisp@mellanox.com,
aviadye@mellanox.com, john.fastabend@gmail.com,
daniel@iogearbox.net
Subject: Re: [PATCH net] net: tls: Save iv in tls_rec for async crypto requests
Date: Mon, 28 Jan 2019 23:06:46 -0800 (PST) [thread overview]
Message-ID: <20190128.230646.1035163245730515543.davem@davemloft.net> (raw)
In-Reply-To: <20190127005735.k3qh34hctskwdvzy@davejwatson-mba.local.dhcp.thefacebook.com>
From: Dave Watson <davejwatson@fb.com>
Date: Sun, 27 Jan 2019 00:57:38 +0000
> aead_request_set_crypt takes an iv pointer, and we change the iv
> soon after setting it. Some async crypto algorithms don't save the iv,
> so we need to save it in the tls_rec for async requests.
>
> Found by hardcoding x64 aesni to use async crypto manager (to test the async
> codepath), however I don't think this combination can happen in the wild.
> Presumably other hardware offloads will need this fix, but there have been
> no user reports.
>
> Fixes: a42055e8d2c30 ("Add support for async encryption of records...")
> Signed-off-by: Dave Watson <davejwatson@fb.com>
Applied and queued up for -stable.
next prev parent reply other threads:[~2019-01-29 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 0:57 [PATCH net] net: tls: Save iv in tls_rec for async crypto requests Dave Watson
2019-01-29 7:06 ` David Miller [this message]
2019-01-29 17:21 ` Dave Watson
2019-01-29 18:57 ` David Miller
2019-01-30 6:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128.230646.1035163245730515543.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=davejwatson@fb.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).