From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C8BC169C4 for ; Tue, 29 Jan 2019 07:06:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F7052177E for ; Tue, 29 Jan 2019 07:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726968AbfA2HGu (ORCPT ); Tue, 29 Jan 2019 02:06:50 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:54464 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726861AbfA2HGt (ORCPT ); Tue, 29 Jan 2019 02:06:49 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 906EA147DD69B; Mon, 28 Jan 2019 23:06:46 -0800 (PST) Date: Mon, 28 Jan 2019 23:06:46 -0800 (PST) Message-Id: <20190128.230646.1035163245730515543.davem@davemloft.net> To: davejwatson@fb.com Cc: netdev@vger.kernel.org, vakul.garg@nxp.com, borisp@mellanox.com, aviadye@mellanox.com, john.fastabend@gmail.com, daniel@iogearbox.net Subject: Re: [PATCH net] net: tls: Save iv in tls_rec for async crypto requests From: David Miller In-Reply-To: <20190127005735.k3qh34hctskwdvzy@davejwatson-mba.local.dhcp.thefacebook.com> References: <20190127005735.k3qh34hctskwdvzy@davejwatson-mba.local.dhcp.thefacebook.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 28 Jan 2019 23:06:46 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dave Watson Date: Sun, 27 Jan 2019 00:57:38 +0000 > aead_request_set_crypt takes an iv pointer, and we change the iv > soon after setting it. Some async crypto algorithms don't save the iv, > so we need to save it in the tls_rec for async requests. > > Found by hardcoding x64 aesni to use async crypto manager (to test the async > codepath), however I don't think this combination can happen in the wild. > Presumably other hardware offloads will need this fix, but there have been > no user reports. > > Fixes: a42055e8d2c30 ("Add support for async encryption of records...") > Signed-off-by: Dave Watson Applied and queued up for -stable.