From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22667C282CF for ; Mon, 28 Jan 2019 16:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E500A2147A for ; Mon, 28 Jan 2019 16:28:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="NxxCMCTJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390643AbfA1Q2d (ORCPT ); Mon, 28 Jan 2019 11:28:33 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:36897 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389465AbfA1Q2c (ORCPT ); Mon, 28 Jan 2019 11:28:32 -0500 Received: by mail-pg1-f196.google.com with SMTP id c25so7425773pgb.4 for ; Mon, 28 Jan 2019 08:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=j+8H9loR0eGaVhsFlffHo/M3oOIvcygakltP7+fNtm4=; b=NxxCMCTJz7kj7nvzHz1uv4EZGlN2kxm+FFoSZC7ki/sxvsmHiPjmzf/ffTrJBu2QsM xzKJpbIK/ahpHwL8MmWXEwG9h6LBCeL9DvvFMsmclK6sfXPyKTdrrTYw5yfTFT8jiHpH 26UPukngqxKnELlkOd4yryVZ11xWmAlGkM3jTSA+XpTAyNh1kWhCZSRNOiyrjDU67h56 4AwVzEt8YElV9TD5QTCH/rzUXlQup0lkZJXv17MAZa7Xhz4AEgSUwsn9g4Uxtp0BZ+aZ DHBM4Wf1mScj1hNdhsJzW0m76ULh7xXAz0e+cj3vZPKGMH2LQFtRgMl7s14Xy3AcwG2g 8zvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=j+8H9loR0eGaVhsFlffHo/M3oOIvcygakltP7+fNtm4=; b=pqur7JN6K55GewiRNho/Oh11Cxd4dTkyvfq4R5qQscFyLt9WDwg4EHt4v38zT/EI9Y CLloGLY5t0suAo+doMNmmN3XWQkMhFJMROz8/PM/T77hMNlbHVRX9uWGuro5K7V43us5 4ZwK3G2s7zZ6VpN/joQh+962MxOvppmnLRMt57qpZaw+9Y4gG+Hsoihyj9/W6S6GERmq a/uMiB9gma5Q2o5VHV8fMLUR9n0JSAvFCSVlX5fuqER/hQSUdmTQWpmQ1ce6qIyDoPC8 mZdT0TvziFY/lrvpNa88QeiErRR54oYdaTz0icb6Li5JvLJf278r0CcXr3rue7K3IjN6 +ydA== X-Gm-Message-State: AJcUukfz/P1TO5iE0Z27UZpumX+aGEtJejFFbsP9d0PwuN+45NQ+183E c87g4+UKbctni13NjVMJjBiTiw== X-Google-Smtp-Source: ALg8bN4YJEwHUR5EGA3g3LctCuHGdV9OORdVfl7if4NoqwgQ8sA8a57ogdrJtDbnXV7BO0c9dSw/fg== X-Received: by 2002:a62:29c3:: with SMTP id p186mr22918293pfp.117.1548692911945; Mon, 28 Jan 2019 08:28:31 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([2601:646:8e00:727e::2]) by smtp.gmail.com with ESMTPSA id p24sm50443786pfk.155.2019.01.28.08.28.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jan 2019 08:28:31 -0800 (PST) Date: Mon, 28 Jan 2019 08:28:25 -0800 From: Jakub Kicinski To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "David S . Miller" , oss-drivers@netronome.com, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.19 094/258] nfp: add locking around representor changes Message-ID: <20190128082825.4c8394a6@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190128155924.51521-94-sashal@kernel.org> References: <20190128155924.51521-1-sashal@kernel.org> <20190128155924.51521-94-sashal@kernel.org> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 28 Jan 2019 10:56:40 -0500, Sasha Levin wrote: > From: Jakub Kicinski > > [ Upstream commit 71844fac1ed459024dd2a448d63d5b28b8c87daa ] > > Up until now we never needed to keep a networking locks around > representors accesses, we only accessed them when device was > reconfigured (under nfp pf->lock) or on fast path (under RCU). > Now we want to be able to iterate over all representors during > notifications, so make sure representor assignment is done > under RTNL lock. > > Signed-off-by: Jakub Kicinski > Reviewed-by: John Hurley > Signed-off-by: David S. Miller > Signed-off-by: Sasha Levin Hi Sasha! There is no need for backporting this unless 51a6588e8c08 ("nfp: add offloads on representors") is also back ported (which is a feature).