From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FC8C282C8 for ; Mon, 28 Jan 2019 12:02:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94208214DA for ; Mon, 28 Jan 2019 12:02:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="rwhYy1Oj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfA1MCV (ORCPT ); Mon, 28 Jan 2019 07:02:21 -0500 Received: from mail-eopbgr30068.outbound.protection.outlook.com ([40.107.3.68]:30567 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726752AbfA1MCU (ORCPT ); Mon, 28 Jan 2019 07:02:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lOwElGmG6Ofik+4lzBp2LV4BHSl1Mmmk1WM2usUvAoM=; b=rwhYy1OjH9atJLxhXor96B6dHiuuX16TQqAI2l+VdbBuoqLKjLqipGkKccBq7m0ZbryfoCFt8zWyvssN2EiZadK1hG+NHBL49uCEy5K9795P5qtPxJ+lA45C5Vn1Jw1Cxuuhi+KxKMSU9Nwm8Wp1CWQrKTK0W9BYK1RlKG6jrnI= Received: from DB7PR05MB4940.eurprd05.prod.outlook.com (20.176.235.152) by DB7PR05MB4250.eurprd05.prod.outlook.com (52.134.108.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1558.21; Mon, 28 Jan 2019 12:02:10 +0000 Received: from DB7PR05MB4940.eurprd05.prod.outlook.com ([fe80::6161:97fd:d315:7b07]) by DB7PR05MB4940.eurprd05.prod.outlook.com ([fe80::6161:97fd:d315:7b07%6]) with mapi id 15.20.1558.023; Mon, 28 Jan 2019 12:02:10 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , mlxsw , Ido Schimmel , David Ahern Subject: [PATCH net-next 4/7] mlxsw: spectrum_switchdev: Add more extack messages Thread-Topic: [PATCH net-next 4/7] mlxsw: spectrum_switchdev: Add more extack messages Thread-Index: AQHUtwFMd2ozMHVoi0OcqsH+fiz6Pw== Date: Mon, 28 Jan 2019 12:02:10 +0000 Message-ID: <20190128120131.2848-5-idosch@mellanox.com> References: <20190128120131.2848-1-idosch@mellanox.com> In-Reply-To: <20190128120131.2848-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P194CA0090.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::31) To DB7PR05MB4940.eurprd05.prod.outlook.com (2603:10a6:10:1e::24) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB7PR05MB4250;6:t3xl3hWjvNXQ7PbmK4bX7rHm7ntb+ZxBgKrfwTXUI9y7k4Eyf5cxg1nj0s6zpNboBcOemSwiY4nzh8t90OtiEOm4k5J5AYBh3yhvAszyn8yYV1iTaFI94m4QzoyAqdoD4cvSrHo5Whq+DfSiec0uPcmUK1Kzzw3mIqPBPiVGpWP9kbBAMAyaXh3GAmx8P/6wqBL1C1151nFjJOVEn6tJVKQawn/SPpSdW+qeCQYbuo5o9izIyo09q7vQitI7sCt6ycAAppSTN7vXiFnCgNXxu1T7H5h9fTi6/kY0mjg+fHvXNVuGCdq375MsH7+qwkch0caqglYOguqmrAkHdANW5XU9DJfh1ocbdVu3wjP+W9rKHpogEsOaDC/V3qwqOtD2VZUHEE0Kli6Qwu2Hwbft2oBaphT1vvYYSsmdisLM+43Uk37V4wA6mxIL2IFHKyJnG0t5RUqTcjVs54j5QlMLXw==;5:8wvUcpk3BYPrlrUAj35fMhv6u3A8JyD5Y3r0/vLLfRVo812Ku1Osy9gcdG0Jsy00UTI350Lio0aL2HCfCDHZQNBNE11a/T+2fisWS02FLbETfUig6kBVMY458/7UaFqyXAX2bM2dNULfIWgmKw8qf6P6YAnBz7UW/Md8B7XExTfQC1LTVArVSouaENOVo+ULnisOlIkim8icFxyRQuFGNA==;7:PYnB0x2GlngmU3QPlvJ+k0bOOkM6psLCNnh3ulEhS056hnF0/oqD4hY2g8g+n/ADungUGbhE9Zp+eVIT23ByQzzSZCo7Tp67a2VDjqZ+xwQ/Ee4DLDA2pwGdPTvqiemNad0r1mHYrEHJJHJMcq+w3w== x-ms-office365-filtering-correlation-id: f26c6842-dce6-478e-ef04-08d685186eb7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:DB7PR05MB4250; x-ms-traffictypediagnostic: DB7PR05MB4250: x-microsoft-antispam-prvs: x-forefront-prvs: 0931CB1479 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(396003)(376002)(136003)(39860400002)(366004)(199004)(189003)(446003)(11346002)(54906003)(478600001)(6916009)(36756003)(305945005)(256004)(86362001)(81156014)(8676002)(6506007)(14454004)(486006)(2616005)(1730700003)(68736007)(105586002)(386003)(52116002)(102836004)(2351001)(476003)(106356001)(7736002)(76176011)(316002)(99286004)(186003)(53936002)(39060400002)(25786009)(26005)(4326008)(81166006)(6486002)(6116002)(3846002)(2501003)(8936002)(97736004)(1076003)(6512007)(15650500001)(5640700003)(2906002)(6436002)(71200400001)(66066001)(71190400001)(50226002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR05MB4250;H:DB7PR05MB4940.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: KRhqVCc2kYwQEHv+/QvQbbMth/fy1iskYymsPaTrsR6zPMroU2s9fnsNopc3DoVJFhP2XgSbGzYfdNwkfLLjGIYIJNmki8AP5Nf1UA8R5T8cgsSIAOP/Mmn1DEJ8Wncihhap6D0fuFcq2/Fzr8/fr9cxtLAIQlTV7HA0vr+tFKB0drh8dCxGZquUfo/w3eDvSf2QrGFyfyZu+gD/9TVNkuJh+2MHlV3UGG/FzYj+NdnDX9BUS6RQyHue0Rf2ndRiFL+DJqTXUWiLfZkklIn/Q7ziX4Ja1woxUVcA6IT25YMVE8ryx6Jiq7WOvonA97QultgLiR7HLoI43vDBpjWyXTyozGNcismDQzkchhEW+LdmoIT65tqTwmOJhAPqqyvtCmI5bRPSVpwmCINwjQbRnDHxsnLzr4jRtXKBUNf7RyA= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f26c6842-dce6-478e-ef04-08d685186eb7 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2019 12:02:09.6056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4250 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add more extack messages that let the user know why VXLAN offload failed. Signed-off-by: Ido Schimmel Suggested-by: David Ahern Cc: David Ahern --- .../net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/dri= vers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c index 0f4e68d31cc3..a4a9fe992193 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c @@ -2027,6 +2027,7 @@ mlxsw_sp_bridge_8021q_vxlan_join(struct mlxsw_sp_brid= ge_device *bridge_device, return 0; =20 if (mlxsw_sp_fid_vni_is_set(fid)) { + NL_SET_ERR_MSG_MOD(extack, "VNI is already set on FID"); err =3D -EINVAL; goto err_vni_exists; } @@ -2213,10 +2214,13 @@ mlxsw_sp_bridge_8021d_vxlan_join(struct mlxsw_sp_br= idge_device *bridge_device, int err; =20 fid =3D mlxsw_sp_fid_8021d_lookup(mlxsw_sp, bridge_device->dev->ifindex); - if (!fid) + if (!fid) { + NL_SET_ERR_MSG_MOD(extack, "Did not find a corresponding FID"); return -EINVAL; + } =20 if (mlxsw_sp_fid_vni_is_set(fid)) { + NL_SET_ERR_MSG_MOD(extack, "VNI is already set on FID"); err =3D -EINVAL; goto err_vni_exists; } @@ -3231,8 +3235,10 @@ mlxsw_sp_switchdev_vxlan_vlan_add(struct mlxsw_sp *m= lxsw_sp, * the lookup function to return 'vxlan_dev' */ if (flag_untagged && flag_pvid && - mlxsw_sp_bridge_8021q_vxlan_dev_find(bridge_device->dev, vid)) + mlxsw_sp_bridge_8021q_vxlan_dev_find(bridge_device->dev, vid)) { + NL_SET_ERR_MSG_MOD(extack, "VLAN already mapped to a different VNI"); return -EINVAL; + } =20 if (!netif_running(vxlan_dev)) return 0; --=20 2.20.1