From: David Miller <davem@davemloft.net>
To: arjun@chelsio.com
Cc: netdev@vger.kernel.org, nirranjan@chelsio.com,
indranil@chelsio.com, dt@chelsio.com, leedom@chelsio.com
Subject: Re: [net-next] cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()
Date: Tue, 29 Jan 2019 09:39:13 -0800 (PST) [thread overview]
Message-ID: <20190129.093913.2116455131788944733.davem@davemloft.net> (raw)
In-Reply-To: <20190129094850.19203-1-arjun@chelsio.com>
From: Arjun Vynipadath <arjun@chelsio.com>
Date: Tue, 29 Jan 2019 15:18:50 +0530
> diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> index 2fab87e..a8f78ea 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> @@ -236,6 +236,74 @@ void t4vf_os_portmod_changed(struct adapter *adapter, int pidx)
> "inserted\n", dev->name, pi->mod_type);
> }
>
> +static inline int cxgb4vf_set_addr_hash(struct port_info *pi)
...
> +static inline int cxgb4vf_change_mac(struct port_info *pi, unsigned int viid,
> + int *tcam_idx, const u8 *addr,
> + bool persistent)
Please do not use the inline keyword in foo.c files.
Thank you.
prev parent reply other threads:[~2019-01-29 17:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 9:48 [net-next] cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac() Arjun Vynipadath
2019-01-29 17:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129.093913.2116455131788944733.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arjun@chelsio.com \
--cc=dt@chelsio.com \
--cc=indranil@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).