From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D69EC169C4 for ; Tue, 29 Jan 2019 17:39:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 374D920844 for ; Tue, 29 Jan 2019 17:39:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728704AbfA2RjR (ORCPT ); Tue, 29 Jan 2019 12:39:17 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33092 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbfA2RjR (ORCPT ); Tue, 29 Jan 2019 12:39:17 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 39BD414F14B64; Tue, 29 Jan 2019 09:39:16 -0800 (PST) Date: Tue, 29 Jan 2019 09:39:13 -0800 (PST) Message-Id: <20190129.093913.2116455131788944733.davem@davemloft.net> To: arjun@chelsio.com Cc: netdev@vger.kernel.org, nirranjan@chelsio.com, indranil@chelsio.com, dt@chelsio.com, leedom@chelsio.com Subject: Re: [net-next] cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac() From: David Miller In-Reply-To: <20190129094850.19203-1-arjun@chelsio.com> References: <20190129094850.19203-1-arjun@chelsio.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Jan 2019 09:39:16 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arjun Vynipadath Date: Tue, 29 Jan 2019 15:18:50 +0530 > diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c > index 2fab87e..a8f78ea 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c > +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c > @@ -236,6 +236,74 @@ void t4vf_os_portmod_changed(struct adapter *adapter, int pidx) > "inserted\n", dev->name, pi->mod_type); > } > > +static inline int cxgb4vf_set_addr_hash(struct port_info *pi) ... > +static inline int cxgb4vf_change_mac(struct port_info *pi, unsigned int viid, > + int *tcam_idx, const u8 *addr, > + bool persistent) Please do not use the inline keyword in foo.c files. Thank you.