From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8933CC169C4 for ; Tue, 29 Jan 2019 18:12:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60AB020857 for ; Tue, 29 Jan 2019 18:12:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727925AbfA2SMB (ORCPT ); Tue, 29 Jan 2019 13:12:01 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33678 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726314AbfA2SMA (ORCPT ); Tue, 29 Jan 2019 13:12:00 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4E6A614F0BB48; Tue, 29 Jan 2019 10:12:00 -0800 (PST) Date: Tue, 29 Jan 2019 10:11:59 -0800 (PST) Message-Id: <20190129.101159.136552412219353385.davem@davemloft.net> To: albin_yang@163.com Cc: netdev@vger.kernel.org, michael.chan@broadcom.com, yang.wei9@zte.com.cn Subject: Re: [PATCH net] net: b44: replace dev_kfree_skb_xxx by dev_consume_skb_xxx for drop profiles From: David Miller In-Reply-To: <1548774280-5757-1-git-send-email-albin_yang@163.com> References: <1548774280-5757-1-git-send-email-albin_yang@163.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 29 Jan 2019 10:12:00 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei Date: Tue, 29 Jan 2019 23:04:40 +0800 > From: Yang Wei > > The skb should be freed by dev_consume_skb_any() in b44_start_xmit() > when bounce_skb is used. The skb is be replaced by bounce_skb, so the > original skb should be consumed(not drop). > > dev_consume_skb_irq() should be called in b44_tx() when skb xmit > done. It makes drop profiles(dropwatch, perf) more friendly. > > Signed-off-by: Yang Wei Applied.