From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE64EC282C7 for ; Tue, 29 Jan 2019 07:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2DBE2177E for ; Tue, 29 Jan 2019 07:58:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="hTubLrSU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbfA2H6j (ORCPT ); Tue, 29 Jan 2019 02:58:39 -0500 Received: from mail-eopbgr80071.outbound.protection.outlook.com ([40.107.8.71]:58656 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725294AbfA2H6h (ORCPT ); Tue, 29 Jan 2019 02:58:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h6APygBlWQKtlT2X13DPOBV0kF6O3YAadT+e63nNRgA=; b=hTubLrSUwBhnCCVDVdCe/fRpArxBfJZbPSozyaJKXNCcbVWoP4ThXpoCWVhma7PECvp3qjU3xp/fDfTnUSlrBYjsfMqK6m2YOxvRm0PkKDgDakGgK+mIrN3NSxNGYpQknvW+vGMRtluEEE/9LLriRTUfDiMRK4uNOr/IBMqFQb4= Received: from DB6PR0501MB2694.eurprd05.prod.outlook.com (10.172.226.9) by DB6PR0501MB2406.eurprd05.prod.outlook.com (10.168.75.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.16; Tue, 29 Jan 2019 07:58:17 +0000 Received: from DB6PR0501MB2694.eurprd05.prod.outlook.com ([fe80::ed9e:f27:4597:6db2]) by DB6PR0501MB2694.eurprd05.prod.outlook.com ([fe80::ed9e:f27:4597:6db2%10]) with mapi id 15.20.1558.023; Tue, 29 Jan 2019 07:58:17 +0000 From: Leon Romanovsky To: Saeed Mahameed CC: "saeedm@dev.mellanox.co.il" , Jason Gunthorpe , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH mlx5-next 0/4] mlx5 next misc updates Thread-Topic: [PATCH mlx5-next 0/4] mlx5 next misc updates Thread-Index: AQHUr46doHAiqwvoPUqPqRHa8q36EaW+Yh+AgAHwkwCAAnhSgIACUEiAgADWXAA= Date: Tue, 29 Jan 2019 07:58:17 +0000 Message-ID: <20190129075814.GC3604@mtr-leonro.mtl.com> References: <20190119003313.16711-1-saeedm@mellanox.com> <20190124123041.GS3604@mtr-leonro.mtl.com> <20190127075109.GY3604@mtr-leonro.mtl.com> <812ce9a19d55ed16af677622a39ee484eb9c508f.camel@mellanox.com> In-Reply-To: <812ce9a19d55ed16af677622a39ee484eb9c508f.camel@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-clientproxiedby: AM6P194CA0077.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::18) To DB6PR0501MB2694.eurprd05.prod.outlook.com (2603:10a6:4:82::9) authentication-results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [77.138.135.184] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR0501MB2406;6:VajG5svesCTvdyVfLWJNu67hq3YGUIQMreOTjy4u8ni87JBs9UdnoMf8iV+YTKtCDMRdyUJd3Uj3MgV7n0zhy2euLeZIDE83qMFPyZtXpWuGWpWKjI+tK3Yv53xJRHvC2sG3v6rhe1+cb9eLfYq5p5Gl87LE8t29HsdMiFOSjS21BEx8WWjlEcigT+rMJAtAq/01Tua3HQ/zH+Jf8tR31oN0mcTD50uWRIIgo7fHyR8QAK82O/7T36u390RP7fHa9J8Yf9gzqHYCRghh1ZOGs6AF2OYN8z/aE/jJt+doiGfEaZqWwYUPCGNicp3PL3RUk47KBD0jpKbVXbGPdRkiDNTjrvO6zuVkFsfQTt8QlKSAx/IjSTpmW+eBLPDnEizaFeh+ZomzkWozBz4uShzL4WG+89UceMDngMx0IHoApiDXws7hWPlALXyQwmxfUKEmvXzgD0n8noA9NfKtVCvnEA==;5:fLmGFE9cpXTA61xYeM5N1dDuKIWRImF64O9RZAHF0u+ROZnSNJA124nzzs1R0phH2Rewriy3qafMdXi66WT0Kyp5JWMkOh7pwvya43tuRbCX89exNP06JobpMA3MZind+TqeDDOz0W3uDWKiW9nv8xv/MqdB3Iu742IYS3042PdTDY0TofaRBXKemUCe+UDzyTiiVAJ60UE4xELTjNv1nQ==;7:dCH0gSFfR92w4W+PcW6MHQXOH+irpsbkH5BYCB35VB+vmwe/MS4YIX/v3mpe9lYkjYnP8AONmJ+9Ai/UDLwlAUdPIvpESA56KM7qUME8YvxJyqkhKvfgIUr1qi4bzeuHdXi+WKWfaJyMqCBKRHbzvA== x-ms-office365-filtering-correlation-id: e528dd07-b13f-4224-6bcb-08d685bf86d7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(49563074)(7193020);SRVR:DB6PR0501MB2406; x-ms-traffictypediagnostic: DB6PR0501MB2406: x-microsoft-antispam-prvs: x-forefront-prvs: 093290AD39 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(136003)(346002)(366004)(376002)(39860400002)(199004)(189003)(53754006)(99286004)(71200400001)(1076003)(6862004)(71190400001)(97736004)(25786009)(66066001)(68736007)(6486002)(6246003)(4326008)(305945005)(229853002)(54906003)(86362001)(52116002)(6512007)(76176011)(53936002)(33656002)(9686003)(7736002)(450100002)(6636002)(6436002)(316002)(15650500001)(93886005)(105586002)(8676002)(26005)(186003)(14454004)(256004)(106356001)(8936002)(14444005)(6116002)(3846002)(2906002)(53546011)(6506007)(81166006)(81156014)(386003)(33896004)(486006)(478600001)(476003)(99936001)(11346002)(446003)(102836004);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0501MB2406;H:DB6PR0501MB2694.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: jLOS0jFxj0M+2bHsbjIFkb5HGvSgjyH8duAjx+4M43caO9yWgtyzl16/KCywXyZkMYlYjLH2hXLRbi9Rgnrx5OogXw1imjBK0XNdyyMJ/FIQpxhaBqB42jQQrAsVXLpIT9VSP8dg68asx8C1iOmo1Ah3iUlhyf0KzU5r9MZDUnFZ7UTo/VOh10gWenlcRkKShn+SlKyZCvlXmnnAIdFmFRCF0yare/TRU2CjOFfoQlWbkCPe0JDGQbBTmUUaHRgvRbefnXjfUHnu3ut3OYUw/+AjcNGiOPvLdw4k7655rNiez4niS25ro0txWiFyyp2yicqry8mSENZd43I4BWonDjAiUn7kxAT7QpMIagE8cxrDZOlPUyvoq9yHa+gA2/QaMrHyAw0DdhFq1Yp1TtsJyWTJa933YkkDTsPgUaqK6q4= Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f6nK9RR+X1IX2pXa" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e528dd07-b13f-4224-6bcb-08d685bf86d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2019 07:58:16.3673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2406 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --f6nK9RR+X1IX2pXa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 28, 2019 at 07:11:01PM +0000, Saeed Mahameed wrote: > On Sun, 2019-01-27 at 07:51 +0000, Leon Romanovsky wrote: > > On Fri, Jan 25, 2019 at 10:08:00AM -0800, Saeed Mahameed wrote: > > > On Thu, Jan 24, 2019 at 4:30 AM Leon Romanovsky < > > > leonro@mellanox.com> wrote: > > > > On Fri, Jan 18, 2019 at 04:33:09PM -0800, Saeed Mahameed wrote: > > > > > Hi all, > > > > > > > > > > This series includes updates to mlx5-next shared branch. > > > > > > > > > > 1) from Jason, improve mlx5_cmd_exec_cb async API to be safer > > > > > 2) from Maxim Mikityanskiy, cleanups for mlx5_write64 doorbell > > > > > API > > > > > 3) from Michael Guralnik, Add pci AtomicOps request > > > > > > > > > > Thanks, > > > > > Saeed. > > > > > > > > > > --- > > > > > > > > > > Jason Gunthorpe (1): > > > > > net/mlx5: Make mlx5_cmd_exec_cb() a safe API > > > > > > > > > > Michael Guralnik (1): > > > > > net/mlx5: Add pci AtomicOps request > > > > > > > > Those two were applied to mlx5-next branch. > > > > > > > > ce4eee5340a9 (mlx5-next) net/mlx5: Add pci AtomicOps request > > > > e355477ed9e4 net/mlx5: Make mlx5_cmd_exec_cb() a safe API > > > > > > > > > Maxim Mikityanskiy (2): > > > > > net/mlx5: Remove unused MLX5_*_DOORBELL_LOCK macros > > > > > net/mlx5: Remove spinlock support from mlx5_write64 > > > > > > > > Those two needs extra work, > > > > > > What extra work ? > > > > You got two comments for area you are touching: > > 1. Replace _rww writes to something else. > > Not related to this cleanup patchset. > > > 2. Protect with spinlock 32-bits writes instead of ignoring it. > > Same as above, I already explained this. > > > > > Both of those changes will touch the same 2-4 lines and there > > is very little benefit in creating more than one-two patches > > just for that. > > > > Future work, as it needs verification and careful testing. > > Leon I would like to move on with those 2 small cleanup patches, no > functionality change here, please confirm you are ok with them. At least write large and scary comment that this mode was always broken. > > Thanks, > Saeed. > > > Thanks > > > > > > Thanks > > > > > > > > > -- > > > > > 2.20.1 > > > > > --f6nK9RR+X1IX2pXa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcUAeWAAoJEORje4g2clindioP/RWWUFn9TaEoqR9boecAd+c/ vr4OgghbeHtUDFn2NEcD2nIAaVXNaSsrBicvzYezK/bxU6oeSNT1GCQroSc7KOba SaxLiOEWM05Lyd5KmSaiEROrfK1iKoaAsUEiEDjLEfZjrUdn0BvvmVGEJJim9sKM gzJiKvXrfNF+/2FKqheze7PdJ3l6VwhsMAJDCfrs/O17EyPBEW93Sr+0nQiIdG7F hr+RZ+3Fy9v/5glIk1GyfvK40ztsS67NXy5uaIfv7IHSmygO9cYEsvFEomRMDjZN oJA/bQKDpqHGALTpbvbABzYCqwKM+xG1QkrUktB0N6/PanwQLIzsFr9voffpyRHV LI0qh5ASJ6aewdiPuGpdYf/2SXYVXeXL3aXRvKA1Rdi+2hqmgWJDIpqud9RJKtwM mE/A0SDEy/plKnYXMXdzHZqE72saZZkIN0NKnjbPo/obyOXisD7RztxC8oBiMFZS yNFkhUnnwMjRHJDstQjkY+BkczUnO2kjra47ViC/pc4KIVD3WsQwuGseCm7v3zTf KgMARZHwVTAPexqZxzh5HzPoZLUZKTyNTR1eathULy56IPF8zpEbEo2pO0TpWioy G1gFGpWNhJGPdj1IbOMM6ZryqCVP60o3992gwnYSD2WoLFGQD6ejcG2DDmJV/AON W3Z3aSIJG4Na9kddEzk1 =qvIa -----END PGP SIGNATURE----- --f6nK9RR+X1IX2pXa--