From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CA5BC282C7 for ; Tue, 29 Jan 2019 09:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 529032084A for ; Tue, 29 Jan 2019 09:10:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="bv5MEO/j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727909AbfA2JKA (ORCPT ); Tue, 29 Jan 2019 04:10:00 -0500 Received: from mail-lj1-f178.google.com ([209.85.208.178]:32975 "EHLO mail-lj1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbfA2JKA (ORCPT ); Tue, 29 Jan 2019 04:10:00 -0500 Received: by mail-lj1-f178.google.com with SMTP id v1-v6so16848363ljd.0 for ; Tue, 29 Jan 2019 01:09:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VC4H9aeLDdUlBCYd95DspueaoZolmcCCC/DBdEJLaa8=; b=bv5MEO/jhqgRprjYPa7w7bk5RURVE+WGdtUR5CLaH9uXHh0SU7BiCttCWCyXOuluQw t0M57MGiZc2zr9sIz0UyKrpml7lwO5b7dkTaJVU1wnEGIwWSM/vQ200yeWB+lr9koB1J 7cPtVoCviSITGFcvs1gXO3xLz32ncEfd0/Lz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VC4H9aeLDdUlBCYd95DspueaoZolmcCCC/DBdEJLaa8=; b=S1ljJSnE1GtwVxXFw5CgXGvUMPdDEnt0M/LfN2Ly7YUqJNKA+xTeHDl5r1nddRXpAk IUZWbnn0wlbBOdJW9ZbGTeB43SHNnDYKUhDFWfUG+1SfV3v+7Q4P0LH2xyszll+jGU/G skw845GZk0HcVL9Ctz3WffhwYtrCzyfSbj5Mw+fhmFl65EeH+Gr+EvZ2o0jfYrXVnliD aqVMj4jo2R24i0J1qFKzN91tQyEpJkHr4mHLY/czqvJyJ8RtYhtNmUteQZ8oQpvHMmgP 8zuRaHFEbYpA1O6s2P1c/7r8bJ+A8MnRyUr39NFr5z24TqtQR9sKCNJC9ecHGAUR0evJ eT3A== X-Gm-Message-State: AJcUukeCSRrVGgfkoVR3XlzoJ2mmzNJuNzQCFsijAxlNCepWjwN1pUFl gFGyKQatrRNXllvyPN8CUYvKQ+8PCP0= X-Google-Smtp-Source: ALg8bN6C0keRRYbZsdCaKeJ1WllX6KqdCJv/tEP1JrZVNZR14amJuljPU0E9bEHn/UmgGSKC4r0t+A== X-Received: by 2002:a2e:841:: with SMTP id g1-v6mr21304137ljd.21.1548752998160; Tue, 29 Jan 2019 01:09:58 -0800 (PST) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id q10-v6sm3440561ljj.3.2019.01.29.01.09.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Jan 2019 01:09:57 -0800 (PST) Date: Tue, 29 Jan 2019 10:09:55 +0100 From: Niklas Cassel To: davem@davemloft.net, stable@vger.kernel.org Cc: netdev@vger.kernel.org, vinod.koul@linaro.org Subject: Re: Request for stable backport: stmmac: Use correct values in TQS/RQS fields Message-ID: <20190129090955.GA16354@centauri.lan> References: <20181219095516.GA7747@centauri.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181219095516.GA7747@centauri.lan> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Adding stable since I see Greg's Sign-off-by on recent backports to this driver. On Wed, Dec 19, 2018 at 10:55:16AM +0100, Niklas Cassel wrote: > Hello David, > > I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac > with multiple tx queues. > > Backporting the following commit: > > commit 52a76235d0c4dd259cd0df503afed4757c04ba1d > Author: Jose Abreu > Date: Fri Oct 13 10:58:36 2017 +0100 > > net: stmmac: Use correct values in TQS/RQS fields > > Currently we are using all the available fifo size in RQS and > TQS fields. This will not work correctly in multi-queues IP's > because total fifo size must be splitted to the enabled queues. > > Correct this by computing the available fifo size per queue and > setting the right value in TQS and RQS fields. > > Signed-off-by: Jose Abreu > Cc: David S. Miller > Cc: Joao Pinto > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > Signed-off-by: David S. Miller > > > resolves the issue. > > The fix was first included in v4.15 > $ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d > v4.15 > v4.15-rc1 > v4.15-rc2 > > Could you please queue it up for 4.14 stable? > > > Kind regards, > Niklas