* Request for stable backport: stmmac: Use correct values in TQS/RQS fields
@ 2018-12-19 9:55 Niklas Cassel
2019-01-29 9:09 ` Niklas Cassel
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Cassel @ 2018-12-19 9:55 UTC (permalink / raw)
To: davem; +Cc: netdev, vinod.koul
Hello David,
I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac
with multiple tx queues.
Backporting the following commit:
commit 52a76235d0c4dd259cd0df503afed4757c04ba1d
Author: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Fri Oct 13 10:58:36 2017 +0100
net: stmmac: Use correct values in TQS/RQS fields
Currently we are using all the available fifo size in RQS and
TQS fields. This will not work correctly in multi-queues IP's
because total fifo size must be splitted to the enabled queues.
Correct this by computing the available fifo size per queue and
setting the right value in TQS and RQS fields.
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
resolves the issue.
The fix was first included in v4.15
$ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d
v4.15
v4.15-rc1
v4.15-rc2
Could you please queue it up for 4.14 stable?
Kind regards,
Niklas
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Request for stable backport: stmmac: Use correct values in TQS/RQS fields
2018-12-19 9:55 Request for stable backport: stmmac: Use correct values in TQS/RQS fields Niklas Cassel
@ 2019-01-29 9:09 ` Niklas Cassel
2019-01-29 9:41 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Niklas Cassel @ 2019-01-29 9:09 UTC (permalink / raw)
To: davem, stable; +Cc: netdev, vinod.koul
Adding stable since I see Greg's Sign-off-by on recent backports
to this driver.
On Wed, Dec 19, 2018 at 10:55:16AM +0100, Niklas Cassel wrote:
> Hello David,
>
> I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac
> with multiple tx queues.
>
> Backporting the following commit:
>
> commit 52a76235d0c4dd259cd0df503afed4757c04ba1d
> Author: Jose Abreu <Jose.Abreu@synopsys.com>
> Date: Fri Oct 13 10:58:36 2017 +0100
>
> net: stmmac: Use correct values in TQS/RQS fields
>
> Currently we are using all the available fifo size in RQS and
> TQS fields. This will not work correctly in multi-queues IP's
> because total fifo size must be splitted to the enabled queues.
>
> Correct this by computing the available fifo size per queue and
> setting the right value in TQS and RQS fields.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
>
> resolves the issue.
>
> The fix was first included in v4.15
> $ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d
> v4.15
> v4.15-rc1
> v4.15-rc2
>
> Could you please queue it up for 4.14 stable?
>
>
> Kind regards,
> Niklas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Request for stable backport: stmmac: Use correct values in TQS/RQS fields
2019-01-29 9:09 ` Niklas Cassel
@ 2019-01-29 9:41 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-01-29 9:41 UTC (permalink / raw)
To: Niklas Cassel; +Cc: davem, stable, netdev, vinod.koul
On Tue, Jan 29, 2019 at 10:09:55AM +0100, Niklas Cassel wrote:
> Adding stable since I see Greg's Sign-off-by on recent backports
> to this driver.
>
>
> On Wed, Dec 19, 2018 at 10:55:16AM +0100, Niklas Cassel wrote:
> > Hello David,
> >
> > I can observe a netdev watchdog timeout on kernel 4.14.78 when using stmmac
> > with multiple tx queues.
> >
> > Backporting the following commit:
> >
> > commit 52a76235d0c4dd259cd0df503afed4757c04ba1d
> > Author: Jose Abreu <Jose.Abreu@synopsys.com>
> > Date: Fri Oct 13 10:58:36 2017 +0100
> >
> > net: stmmac: Use correct values in TQS/RQS fields
> >
> > Currently we are using all the available fifo size in RQS and
> > TQS fields. This will not work correctly in multi-queues IP's
> > because total fifo size must be splitted to the enabled queues.
> >
> > Correct this by computing the available fifo size per queue and
> > setting the right value in TQS and RQS fields.
> >
> > Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> > Cc: David S. Miller <davem@davemloft.net>
> > Cc: Joao Pinto <jpinto@synopsys.com>
> > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> > Cc: Alexandre Torgue <alexandre.torgue@st.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> >
> >
> > resolves the issue.
> >
> > The fix was first included in v4.15
> > $ git tag --contains 52a76235d0c4dd259cd0df503afed4757c04ba1d
> > v4.15
> > v4.15-rc1
> > v4.15-rc2
> >
> > Could you please queue it up for 4.14 stable?
Netdev doesn't care about 4.14 anymore, so I'll just take it, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-29 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-19 9:55 Request for stable backport: stmmac: Use correct values in TQS/RQS fields Niklas Cassel
2019-01-29 9:09 ` Niklas Cassel
2019-01-29 9:41 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).