From: Vivien Didelot <vivien.didelot@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>
Subject: Re: [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules
Date: Tue, 29 Jan 2019 10:46:13 -0500 [thread overview]
Message-ID: <20190129104613.GC20920@t480s.localdomain> (raw)
In-Reply-To: <20190129145157.GK4765@lunn.ch>
Hi Miquèl,
On Tue, 29 Jan 2019 15:51:57 +0100, Andrew Lunn <andrew@lunn.ch> wrote:
> > Today, there is no S2RAM support for switches. First, I proposed to add
> > suspend/resume callbacks to the mv88e6xxx driver - just enough to avoid
> > crashing the kernel.
>
> Then i would suggest the mv88e6xxx refuses the suspend. Actually that
> probably is the first correct step. We don't have suspend support, so
> stop the suspend happening, so preventing the kernel crash.
I am not confortable with adding support for S2RAM in mv88e6xxx yet because
as it was explained, we are aware of much complicated scenarios out there
to pretend that DSA /partly/ supports suspend-resume. The prefered approach
for the moment is to keep things simple and not supporting this feature yet,
especially at the mv88e6xxx driver level.
However crashing is unacceptable so I'm backing Andrew's point here, please
submit a fix to prevent the suspend (and crash) for the moment.
Sorry if you felt that your work is being delayed, it is much appreciated!
Thanks,
Vivien
next prev parent reply other threads:[~2019-01-29 15:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 9:55 [PATCH net-next v2 0/2] mv88e6xxx DSA suspend to RAM support Miquel Raynal
2019-01-25 9:55 ` [PATCH net-next v2 1/2] net: dsa: mv88e6xxx: Save switch rules Miquel Raynal
2019-01-25 18:37 ` Florian Fainelli
2019-01-28 14:24 ` Miquel Raynal
2019-01-28 14:44 ` Andrew Lunn
2019-01-28 15:57 ` Miquel Raynal
2019-01-28 17:42 ` Andrew Lunn
2019-01-29 9:01 ` Miquel Raynal
2019-01-29 14:51 ` Andrew Lunn
2019-01-29 15:46 ` Vivien Didelot [this message]
2019-01-30 9:46 ` Miquel Raynal
2019-01-30 14:54 ` Andrew Lunn
2019-01-31 0:46 ` Vivien Didelot
2019-02-01 11:01 ` Miquel Raynal
2019-02-01 14:08 ` Andrew Lunn
2019-02-01 14:43 ` Miquel Raynal
2019-01-25 9:55 ` [PATCH net-next v2 2/2] net: dsa: mv88e6xxx: Add suspend to RAM support Miquel Raynal
2019-01-27 21:22 ` [PATCH net-next v2 0/2] mv88e6xxx DSA " David Miller
2019-01-27 21:46 ` Andrew Lunn
2019-01-28 3:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129104613.GC20920@t480s.localdomain \
--to=vivien.didelot@gmail.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox