From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB03DC169C4 for ; Tue, 29 Jan 2019 23:21:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90D3C2175B for ; Tue, 29 Jan 2019 23:21:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JFbsZmBZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730076AbfA2XVj (ORCPT ); Tue, 29 Jan 2019 18:21:39 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:42727 "EHLO mail-qt1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729797AbfA2XVj (ORCPT ); Tue, 29 Jan 2019 18:21:39 -0500 Received: by mail-qt1-f181.google.com with SMTP id d19so24309846qtq.9 for ; Tue, 29 Jan 2019 15:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=u6gv+yeiVw+kcTRtLmhFk1y7ttxcF+3pLDJhyzpDpzU=; b=JFbsZmBZC8Fanpmxh4Fti3gYxMSViMy6rYxOZX7+PJbPAN4usABHm7532H9alzNs0Z 77iTkhFA8+xqyMjR4WuMzgwKPWgsIN+03OfjK8nBKNBxNJA5xi19xxFTBGN/7BjIQ1Fg 1IQGikKQ4GlnfjdrlxRLlaPZsWLSzgeof/gmU3akOduAOFKdXjHG2JwalY/cJKlIpTha 0hWUYbvdQrzjbN6l04bY++vY+lK29Q9RVNkaTroF1yRoEgnN19ndKrD5UkNjdKjKRZ8C dxtdIte3zK/iSnv3Cqt9P8SPjaYVdlvgj1QkhJfw4rNOrSOeJw0QUVGJ7G5VoH/P+x/s y4kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=u6gv+yeiVw+kcTRtLmhFk1y7ttxcF+3pLDJhyzpDpzU=; b=Q0y6sj+WytGvS2q6BeLRp583Q0aOR1LfvB6/kNK6II0AYtBwqf84tFzDKfUYYRwrsc 23pMTt9HFcaxYKz36eWfcZITXh4pefJwy/QNW5TE+PGGHIMQg81O0JrGIHAHSPf8atw3 9y6ybU164ql3O+MhbJFaPqzxLWtAFmQlPYkc1IYsVSfPGYDAuK/Q2N7OMrXCffVzkZTM JYdwIhw87GfPP5pzZ4lqXSfmIg351dgUYjt3aEkCeQHE4a0FStvyYbc4lMxBJU0cfEut jWwNnBRB17JAO4/lsI4fnN4xk/QiObIw26zRRlNNWHJWJ5fQFAiKvBGVnMe5x/J5mAOc LUGA== X-Gm-Message-State: AJcUukevxSUZOgl/dLCqRGnjSrvartRr8gt4JfUy+ZRo/wSRQ+qICreT FYx6JtQnJlQwrkk3N2v/2Yg= X-Google-Smtp-Source: ALg8bN4c54DiGkrtZlt+73Hax3hPZonUjWCktXo36/0IWGaW8EvmDRJMZwTwbCa6iKO/GrSmopg+9Q== X-Received: by 2002:aed:2fc4:: with SMTP id m62mr26366691qtd.8.1548804097508; Tue, 29 Jan 2019 15:21:37 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id 5sm108911941qtw.50.2019.01.29.15.21.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Jan 2019 15:21:36 -0800 (PST) Date: Tue, 29 Jan 2019 18:21:35 -0500 Message-ID: <20190129182135.GB19424@t480s.localdomain> From: Vivien Didelot To: Pavel Machek Cc: Andrew Lunn , netdev@vger.kernel.org, f.fainelli@gmail.com, buytenh@marvell.com, buytenh@wantstofly.org, nico@marvell.com Subject: Re: mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?) In-Reply-To: <20190129225732.GA11686@amd> References: <20181115195111.GA9946@amd> <20181115202618.GF32274@lunn.ch> <20181118180712.GA16507@amd> <20181118182053.GE7446@lunn.ch> <20190129225732.GA11686@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Pavel, On Tue, 29 Jan 2019 23:57:32 +0100, Pavel Machek wrote: > Ok, so I took a long look at mv88e6xxx... and got it to work. > > Good news is that modifications needed are not too heavy. Most are > inlined below. (tag_daddr is still needed. I can send that too). > > Bad news is that only about half of all the registers are present on > 6065 (6060 is similar), and I'm not sure how to do that > cleanly. Anything marked "W" is not present or reserved or different > in 6065. What would be good markup of registers that are common to all > and that are newer-generations-only be? Mark everything not present on > 6065 as MV88E6085_*? > > Is someone is interested in getting 6060 to work with mv88e6xxx? I am currently trying to request boards with an 88E6060 so that we can finally get rid of the legacy code used by the mv88e6060 driver. I think the 6065 has similar registers layout than the 6060. If so, it would be simpler for you to add the 6065 support into the mv88e6060 driver. Merging mv88e6060 into mv88e6xxx is the next step I have on my plate after removing legacy. Are you using the legacy binding with mv88e6xxx or the new ones? If you're using the new ones, Andrew may have a patch to convert the mv88e6060 driver to use the new bindings, that you could apply and test first. Then you can add support for 88E6065 in the mv88e6060 driver more easily. Thanks, Vivien