From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A59C169C4 for ; Tue, 29 Jan 2019 21:00:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EAB82147A for ; Tue, 29 Jan 2019 21:00:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729601AbfA2VAQ (ORCPT ); Tue, 29 Jan 2019 16:00:16 -0500 Received: from charlotte.tuxdriver.com ([70.61.120.58]:55850 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbfA2VAP (ORCPT ); Tue, 29 Jan 2019 16:00:15 -0500 Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1goaUO-0008UP-EE; Tue, 29 Jan 2019 16:00:12 -0500 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (8.15.2/8.14.6) with ESMTP id x0TKlpLP013806; Tue, 29 Jan 2019 15:47:51 -0500 Received: (from linville@localhost) by localhost.localdomain (8.15.2/8.15.2/Submit) id x0TKlovE013803; Tue, 29 Jan 2019 15:47:50 -0500 Date: Tue, 29 Jan 2019 15:47:50 -0500 From: "John W. Linville" To: Michal Kubecek Cc: Maciej =?utf-8?Q?=C5=BBenczykowski?= , netdev@vger.kernel.org Subject: Re: ethtool - manual changes in ethtool-copy.h Message-ID: <20190129204749.GD11815@tuxdriver.com> References: <20190129202842.GI24651@unicorn.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129202842.GI24651@unicorn.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 29, 2019 at 09:28:42PM +0100, Michal Kubecek wrote: > Hello, > > I'm sorry I didn't notice earlier but ethtool commit 4df55c81996d > ("ethtool: change to new sane powerpc64 kernel headers") adds changes to > ethtool-copy.h which are not in sync with kernel file it is generated > from. > > This file is supposed to be a copy of the sanitized kernel UAPI header, > i.e. what you get as include/linux/ethtool.h by "make headers_install" > in kernel tree. (The copy in ethtool git is currently a bit behind but > the missing recent changes only modify comments so that it's not really > a problem.) > > Modifying this file manually would mean that anyone who would update it > in the future (to sync with kernel changes) could not simply copy the > sanitized kernel header but would have to make sure to add your fragment > to it. > > As you only need to define the __SANE_USERSPACE_TYPES__ macro (on > ppc64), it might be possible to achieve the same goal in Makefile. > > Michal Kubecek Ooops -- thanks for noticing that Michal! Maciej, how soon might you be able to address this? What is the effect of simply reverting it? Just warnings on ppc64 builds? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.