From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B07C282D8 for ; Wed, 30 Jan 2019 23:10:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D505218AF for ; Wed, 30 Jan 2019 23:10:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729327AbfA3XJ7 (ORCPT ); Wed, 30 Jan 2019 18:09:59 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:52284 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726799AbfA3XJ7 (ORCPT ); Wed, 30 Jan 2019 18:09:59 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2AF6014F51957; Wed, 30 Jan 2019 13:53:14 -0800 (PST) Date: Wed, 30 Jan 2019 13:53:13 -0800 (PST) Message-Id: <20190130.135313.1543764663124902509.davem@davemloft.net> To: ramin.blackhat@gmail.com Cc: herbert@gondor.apana.org.au, steffen.klassert@secunet.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: esp4: Fix double free on esp4 functions From: David Miller In-Reply-To: <20190130213542.17313-1-ramin.blackhat@gmail.com> References: <20190130213542.17313-1-ramin.blackhat@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Jan 2019 13:53:14 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ramin Farajpour Cami Date: Wed, 30 Jan 2019 21:35:42 +0000 > key/tmp is being kfree'd twice,once in the "aalg_desc->uinfo.auth.icv_fullbits / 8 != crypto_aead_authsize(aead)" call > to "free_key",twice When "crypto_aead_setauthsize(aead, x->aalg->alg_trunc_len / 8)" fails call to again "free_key", > > Signed-off-by: Ramin Farajpour Cami > --- > net/ipv4/esp4.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c > index 5459f41fc26f..5a66e47641b0 100644 > --- a/net/ipv4/esp4.c > +++ b/net/ipv4/esp4.c > @@ -467,6 +467,7 @@ int esp_output_tail(struct xfrm_state *x, struct sk_buff *skb, struct esp_info * > > error_free: > kfree(tmp); > + tmp = NULL; > error: > return err; > } This makes no sense at all, the function returns right after the kfree() and tmp is never referenced again!