From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=auZG=QG=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id F090CC282D7
	for <netdev@archiver.kernel.org>; Wed, 30 Jan 2019 23:14:59 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id AD15920881
	for <netdev@archiver.kernel.org>; Wed, 30 Jan 2019 23:14:59 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728419AbfA3XO6 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 30 Jan 2019 18:14:58 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:52332 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726802AbfA3XO6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 30 Jan 2019 18:14:58 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 8A77114F5195F;
        Wed, 30 Jan 2019 13:58:04 -0800 (PST)
Date:   Wed, 30 Jan 2019 13:58:03 -0800 (PST)
Message-Id: <20190130.135803.1455746285854639679.davem@davemloft.net>
To:     tuba@ece.ufl.edu
Cc:     netdev@vger.kernel.org
Subject: Re: [PATCH] : net : hso : do not call unregister_netdev if not
 registered
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1548692918696.27977@ece.ufl.edu>
References: <1548692918696.27977@ece.ufl.edu>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Jan 2019 13:58:04 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: "Yavuz, Tuba" <tuba@ece.ufl.edu>
Date: Mon, 28 Jan 2019 16:28:38 +0000

> On an error path inside the hso_create_net_device function of the hso 
> driver, hso_free_net_device gets called. This causes potentially a 
> negative reference count in the net device if register_netdev has not 
> been called yet as hso_free_net_device calls unregister_netdev 
> regardless. I think the driver should distinguish these cases and call 
> unregister_netdev only if register_netdev has been called.
> 
> Reported-by: Tuba Yavuz <tuba@ece.ufl.edu>
> Signed-off-by: Tuba Yavuz <tuba@ece.ufl.edu>

This does not apply cleanly to the net tree.

Also, please stop putting those spaces after the subsystem prefixes
in your Subject line.  Put the colon character immediately after
each subsystem prefix.

Thank you.