From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C996C282D7 for ; Wed, 30 Jan 2019 23:20:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 379A720881 for ; Wed, 30 Jan 2019 23:20:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730115AbfA3XT6 (ORCPT ); Wed, 30 Jan 2019 18:19:58 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:52366 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727057AbfA3XT6 (ORCPT ); Wed, 30 Jan 2019 18:19:58 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D632714F5196E; Wed, 30 Jan 2019 14:03:00 -0800 (PST) Date: Wed, 30 Jan 2019 14:03:00 -0800 (PST) Message-Id: <20190130.140300.1563734650837653016.davem@davemloft.net> To: makita.toshiaki@lab.ntt.co.jp Cc: mst@redhat.com, jasowang@redhat.com, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, willemb@google.com, brouer@redhat.com Subject: Re: [PATCH v2 net 0/7] virtio_net: Fix problems around XDP tx and napi_tx From: David Miller In-Reply-To: <1548722759-2470-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> References: <1548722759-2470-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Jan 2019 14:03:01 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Toshiaki Makita Date: Tue, 29 Jan 2019 09:45:52 +0900 > While I'm looking into how to account standard tx counters on XDP tx > processing, I found several bugs around XDP tx and napi_tx. > > Patch1: Fix oops on error path. Patch2 depends on this. > Patch2: Fix memory corruption on freeing xdp_frames with napi_tx enabled. > Patch3: Minor fix patch5 depends on. > Patch4: Fix memory corruption on processing xdp_frames when XDP is disabled. > Also patch5 depends on this. > Patch5: Fix memory corruption on processing xdp_frames while XDP is being > disabled. > Patch6: Minor fix patch7 depends on. > Patch7: Fix memory corruption on freeing sk_buff or xdp_frames when a normal > queue is reused for XDP and vise versa. > > v2: > - patch5: Make rcu_assign_pointer/synchronize_net conditional instead of > _virtnet_set_queues. > - patch7: Use napi_consume_skb() instead of dev_consume_skb_any() > > Signed-off-by: Toshiaki Makita Series applied.