From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554F1C282D4 for ; Wed, 30 Jan 2019 07:38:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AE2E2087F for ; Wed, 30 Jan 2019 07:38:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="mV1FLQJC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730081AbfA3Hi0 (ORCPT ); Wed, 30 Jan 2019 02:38:26 -0500 Received: from mail-eopbgr40046.outbound.protection.outlook.com ([40.107.4.46]:10560 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725819AbfA3HiZ (ORCPT ); Wed, 30 Jan 2019 02:38:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nSNTwmCUhftrUbsMECTKSfL+KHftcg3WkHsYt2aJNio=; b=mV1FLQJCN/c/23xkbXHOUYOHUQVFyhS6V1DqMYi/6Rq9/FTGWyRMkifdsC3cClEpvtLkTkVWHxbDE4wMyDnsJQR4twznlytksRPEADe196NhbXSziQhOb4xrk9t/IiAoANFWKWASVYkez1/rH6dVutjZ0y/lyFM93+u6cofS/6c= Received: from DB7PR05MB4940.eurprd05.prod.outlook.com (20.176.235.152) by DB7PR05MB5788.eurprd05.prod.outlook.com (20.178.106.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1580.17; Wed, 30 Jan 2019 07:38:22 +0000 Received: from DB7PR05MB4940.eurprd05.prod.outlook.com ([fe80::6161:97fd:d315:7b07]) by DB7PR05MB4940.eurprd05.prod.outlook.com ([fe80::6161:97fd:d315:7b07%6]) with mapi id 15.20.1558.023; Wed, 30 Jan 2019 07:38:22 +0000 From: Ido Schimmel To: Florian Fainelli CC: "netdev@vger.kernel.org" , "andrew@lunn.ch" , "vivien.didelot@gmail.com" , "davem@davemloft.net" , Jiri Pirko , "ilias.apalodimas@linaro.org" , "ivan.khoronzhuk@linaro.org" , "roopa@cumulusnetworks.com" , "nikolay@cumulusnetworks.com" Subject: Re: [PATCH net-next v2 00/12] net: dsa: management mode for bcm_sf2 Thread-Topic: [PATCH net-next v2 00/12] net: dsa: management mode for bcm_sf2 Thread-Index: AQHUuDbR+8886ySqoUuuO5Gd70N3J6XHbR0A Date: Wed, 30 Jan 2019 07:38:22 +0000 Message-ID: <20190130073820.GB22227@splinter> References: <20190130005548.2212-1-f.fainelli@gmail.com> In-Reply-To: <20190130005548.2212-1-f.fainelli@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P193CA0010.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:3e::23) To DB7PR05MB4940.eurprd05.prod.outlook.com (2603:10a6:10:1e::24) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB7PR05MB5788;6:QZSAFWhkBEDFEvSQ5GtJan3sz+5Qu8WO7kbOI9BG3lHVyhaUmYxmDUui1tBRSPLB3atxCF1Ud8wEVWGSByq/x427TAf1RPnLIZQM2JrA1EnOl+l/kfJQ+0das2X4M5qyaOdxYqJxrA7WjSxeCy3Y6mWXwoFclGTec9731DF9Qj+8qvNtVdzW6OLP5XGJptJIvXNeS0nLQVlsmqeE8hYg2PbiiDluIE1zS9T5aH15Nt6zyJwmph3VaDeQhaTPrHHsOI0Lf2WueESnXP99UO/D8NbYnMesWS9VdK6cXbVe1W6yHZuF/ZCRIG6Wpz4nqMwN0cIC5/6k0DzBScTQBHH+sN/vOvNRYEuENmeEJ9MOvuLtMUx+p2Anc0v/NlA8YDokVd5ha+/BkbEO5Aq3MiTurTQgdpiBmhFa5NlAGicUzrd2xm6xnrop84IQnsJ/5p445C3nGkTWRSUsVipg4Gq1XA==;5:EoT28USEeRK1i/9swfKevKKWIPHF5g10rfHUa5UwjYc5Hk/vV9UWs6iVkYYIHE9FcecwNLkhTQ97fggiq15qAKQHYaXiYzLo0MaYNFYDhQT/LrWatkIlA1wYjKm6BM/OoiT5PG0uLO33JPtcj6oFy5fI25tXBenpfvRP868popbQS1CxbDyNq2zW8dTJs+DKvk4WmGQNlay47pMteZ7q6w==;7:HiErqSdGN+f7yDyRwGdpyUSiH13KS3yAzbXH/36qBqT3luyqhmyeTiRBZoRC5VLXXH/NW2huohyOM9Tq7upvu9+3QrMHcEBFNcjeeabSlbfVlcAhqj4o73hogHuto1udGmi4SafMAHbR06STYV/iGQ== x-ms-office365-filtering-correlation-id: 9b6dcf76-3f4e-4212-225d-08d68685e965 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:DB7PR05MB5788; x-ms-traffictypediagnostic: DB7PR05MB5788: x-microsoft-antispam-prvs: x-forefront-prvs: 0933E9FD8D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(346002)(376002)(39860400002)(136003)(366004)(396003)(53754006)(189003)(199004)(6916009)(256004)(71190400001)(14444005)(6436002)(76176011)(25786009)(2906002)(8936002)(71200400001)(8676002)(81156014)(81166006)(66066001)(9686003)(53936002)(97736004)(99286004)(33896004)(6512007)(86362001)(11346002)(476003)(446003)(478600001)(68736007)(486006)(33716001)(52116002)(316002)(6506007)(386003)(105586002)(6116002)(14454004)(1076003)(106356001)(3846002)(102836004)(54906003)(4326008)(7736002)(33656002)(6486002)(6246003)(186003)(39060400002)(229853002)(305945005)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR05MB5788;H:DB7PR05MB4940.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 14pohJHR6CN30N7Ru2iiq87iC8gAX+eZBqUw73U44UNHtMcOo4vW5gvA4xRfbHotz589NHvr6em0V0yoQvPzgA1nOSwJFW1KvlXiS3EuXCcUEzZpOxTvmlNbHFrGtbC0zrPn7YtFEO1f5EuK3y8BDP/5YceH3T75lb6dDukuMNcLQXfu8ixm8xxHtBujXnwZ3Uwd9VBAM46rLK32HaCTzwqQIMwmsV9aU0ltUQ1abQl6QxK1SQe+43/v4HpTOo8jSS6bdzbF8a8a/QVO8/tKEmclyOuAztESsedGAaRpI4Nl1fcLGjmqe4VSDgvKfttSO1rRGJW0Lgh2QxlLwZh6fk/gIh6im2OruyoS+YCLfx7w1/SBrpXEPAwi54uiUdMHOlWNgzeD4LLiy66WYIlPXep9fKxfZE1W7dv1J3L1KMo= Content-Type: text/plain; charset="us-ascii" Content-ID: <26C9765E98D7DC458C980EA43644D9B7@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b6dcf76-3f4e-4212-225d-08d68685e965 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2019 07:38:22.1763 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB5788 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 29, 2019 at 04:55:36PM -0800, Florian Fainelli wrote: > Hi all, >=20 > This patch series does a number of things in order to enable management > mode for bcm_sf2 (which could be easily extended to b53 with proper > testing later on). In order to get there, there were several use cases > that did not work correctly and that needed to be fixed: >=20 > - VLAN devices on top of switch ports not being member of a bridge, with > other switch ports being bridged, with the bridge having VLAN > filtering enabled. >=20 > - lack of multicast filtering by default on network ports which should > be happening in order for the non-bridged DSA ports to behave strictly > as Ethernet NICs with proper filering. This is accomplished by hooking > a ndo_set_rx_mode() function to the DSA slave network devices >=20 > - when VLAN filtering is globally enabled on the switch (because at > least a bridge device requires it), then we also need to make sure > that when doing multicast over VLAN devices over a switch port > (bridged or not) happens with the correct MDB address *and* VID >=20 > Hopefully the changes to net/8021q and net/bridge are deemed acceptable. You're not touching net/8021q :) Probably leftover from v1 ... >=20 > drivers/net/dsa/b53/b53_common.c | 257 +++++++++++++++++++-- > drivers/net/dsa/b53/b53_priv.h | 14 +- > drivers/net/dsa/b53/b53_regs.h | 22 ++ > drivers/net/dsa/bcm_sf2.c | 56 +++-- > drivers/net/dsa/bcm_sf2_regs.h | 5 + > drivers/net/ethernet/broadcom/bcmsysport.c | 4 + > include/net/dsa.h | 2 + > net/bridge/br_multicast.c | 23 +- > net/dsa/dsa_priv.h | 22 +- > net/dsa/port.c | 42 +++- > net/dsa/slave.c | 107 ++++++++- > net/dsa/switch.c | 57 +++++ > 12 files changed, 552 insertions(+), 59 deletions(-) >=20 > --=20 > 2.17.1 >=20