From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5005C282D7 for ; Wed, 30 Jan 2019 17:44:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8FD82087F for ; Wed, 30 Jan 2019 17:44:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ChP1RKy3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732624AbfA3Roz (ORCPT ); Wed, 30 Jan 2019 12:44:55 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:38039 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732527AbfA3Roz (ORCPT ); Wed, 30 Jan 2019 12:44:55 -0500 Received: by mail-qk1-f194.google.com with SMTP id m17so244784qki.5 for ; Wed, 30 Jan 2019 09:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=uwsAAs70q9TAu6bVWfbrsm4mZGOK+0JLws9g21cQs4M=; b=ChP1RKy3xjblzp3CE1cLQiK+e1FrzRlqu71571qz8RN2Zx62h3bdj7gAkmzFRg9MPB b5ZhRhiguhhbCpz00ZN2fci9IjaPH8kkJ9cL4C6bRy8Rfvz3Gn4swLakOtJdKKq6dlP+ QvGYE5BRJHIU9SF6MT0rGA6YanLezJMWpr9/NMp+ykKmnPnfah0taRcpf1GK0n/rDjM7 Y+QVx63UDPjTjHoPy5fKT4+XUR//3NVj4loW1Qq9Xo/n6zzgEqXmZG7pYKwbWd9jI5s3 OrrTCmnlxfcNMSSj9OU8BkLXApBcDwxgm1TI2TAqRhpcQ5wp9cJNloiTtVlU3438GyEO 0FGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=uwsAAs70q9TAu6bVWfbrsm4mZGOK+0JLws9g21cQs4M=; b=qvI2yUtTHqyTlinBmysSiCbIKMyu/mJPfzSeMboLuL0GmFtD+ABXTs74VSDzbDTU21 q5zJma0HlZyWI2qMdPawpExLfBJSI9/ZpgiXzvB5UhURKAo4FpXkIqCEb90Q5ptYTU3C aMJjxU227EVdDQn7u72Vs7EcLmM2eUgfOJCNfzKt3a1STcTaKz4fdpcOV5aM81OodPGo w/2skWSlInubuscYJvMVNrgT84i8TxM4HH6NzoTtLgens50I5B/htpo+J1d7c5baI0eL i58rsk4gBbVd1jkMAE2I1TOP+yhz26xCMCDQOQWqrgJIWfNbocklTFrizh/mrPGSto6P D8vA== X-Gm-Message-State: AJcUukcED6osaCsSlUiIsfJg2zBCEWepxGRbWgwLrFanQHfeV1q1Eb/d 52lES39pr6X3VHpuE0aY/Ag3Kg== X-Google-Smtp-Source: ALg8bN59zwgO0UPBzOUYm3LV9SHPIyPVTZBRbk82y9oPxT02/oEZQCvHn6Jm0uW5nFxoTamwa22/AA== X-Received: by 2002:a37:c946:: with SMTP id q67mr29331961qki.145.1548870293856; Wed, 30 Jan 2019 09:44:53 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id 18sm2627893qki.35.2019.01.30.09.44.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 09:44:53 -0800 (PST) Date: Wed, 30 Jan 2019 09:44:44 -0800 From: Jakub Kicinski To: David Ahern Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org, jiri@resnulli.us, f.fainelli@gmail.com, andrew@lunn.ch, mkubecek@suse.cz, simon.horman@netronome.com, jesse.brandeburg@intel.com, maciejromanfijalkowski@gmail.com, vasundhara-v.volam@broadcom.com, michael.chan@broadcom.com, shalomt@mellanox.com, idosch@mellanox.com Subject: Re: [RFC 03/14] net: hstats: add basic/core functionality Message-ID: <20190130094444.204c46b7@cakuba.hsd1.ca.comcast.net> In-Reply-To: References: <20190128234507.32028-1-jakub.kicinski@netronome.com> <20190128234507.32028-4-jakub.kicinski@netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 29 Jan 2019 21:18:28 -0700, David Ahern wrote: > On 1/28/19 4:44 PM, Jakub Kicinski wrote: > > @@ -4946,6 +4964,9 @@ static size_t if_nlmsg_stats_size(const struct net_device *dev, > > rcu_read_unlock(); > > } > > > > + if (stats_attr_valid(filter_mask, IFLA_STATS_LINK_HSTATS, 0)) > > filter_mask is populated by RTEXT_FILTER_ from > include/uapi/linux/rtnetlink.h ext_filter_mask is from IFLA_EXT_MASK and has RTEXT_FILTER_ bits set. Here the mask is from struct if_stats_msg::filter_mask of RTM_GETSTATS. Am I missing the point? :S > > + size += rtnl_get_link_hstats_size(dev); > > rtnl_get_link_hstats_size == __rtnl_get_link_hstats can return < 0. Ups! Thank you! In general how much do you dislike this code? :) > > + > > return size; > > } > > > > >