From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: Phil Sutter <phil@nwl.cc>, Eric Garver <egarver@redhat.com>,
Tomas Dolezal <todoleza@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Lennert Buytenhek <buytenh@gnu.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script
Date: Wed, 30 Jan 2019 11:55:55 +0100 [thread overview]
Message-ID: <20190130115555.61868ab9@redhat.com> (raw)
In-Reply-To: <8b930eb8-6ffe-d03f-02a3-12a332edbba3@gmail.com>
Hi David,
On Tue, 29 Jan 2019 21:51:24 -0700
David Ahern <dsahern@gmail.com> wrote:
> On 1/18/19 10:00 AM, Stefano Brivio wrote:
> > This script wraps 'ip' and 'bridge' tools to provide a drop-in replacement
> > of the standalone 'brctl' utility.
> >
> > It's bug-to-bug compatible with brctl as of bridge-utils version 1.6,
> > has no dependencies other than a POSIX shell, and it's less than half
> > the binary size of brctl on x86_64.
> >
> > As many users (including myself) seem to find brctl usage vastly more
> > intuitive than ip-link, possibly due to habit, this might be a lightweight
> > approach to provide brctl syntax without the need to maintain bridge-utils
> > any longer.
> >
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> > Acked-by: Phil Sutter <phil@nwl.cc>
> > ---
> > man/man8/Makefile | 5 +-
> > man/man8/ip-brctl.8 | 187 +++++++++++++++
> > misc/Makefile | 9 +-
> > misc/ip-brctl.in | 572 ++++++++++++++++++++++++++++++++++++++++++++
> > 4 files changed, 770 insertions(+), 3 deletions(-)
> > create mode 100644 man/man8/ip-brctl.8
> > create mode 100755 misc/ip-brctl.in
>
> I get your intent, but this seems more appropriate for you / Red Hat to
> carry than something we want to distribute as part of iproute2.
Sure, I could also do that, but:
- me creating another project: similar maintenance burden for
distribution maintainers as keeping bridge-utils around,
for something that won't have any active development
- carrying it in a single distribution downstream: I would have gone
that way if I thought it wouldn't be useful for others. I myself use
(also) distributions other than Fedora/RHEL and this would feel
just... wrong
Why do you think it's not appropriate to distribute this as part of
iproute2? Too ugly? Bloated? Anything I can improve?
I think it would be appropriate because it intimately depends on
ip-link -- it's really nothing more than a helper for iproute2 tools.
--
Stefano
next prev parent reply other threads:[~2019-01-30 10:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 17:00 [PATCH iproute2-next] Introduce ip-brctl shell script Stefano Brivio
2019-01-23 15:09 ` Nikolay Aleksandrov
2019-01-23 16:33 ` Roopa Prabhu
2019-01-25 10:05 ` Stefano Brivio
2019-01-28 5:08 ` Roopa Prabhu
2019-01-28 7:57 ` Stefano Brivio
2019-01-30 22:30 ` Roopa Prabhu
2019-01-31 12:46 ` Stefano Brivio
2019-01-31 16:28 ` Roopa Prabhu
2019-02-05 22:50 ` Stephen Hemminger
2019-02-06 10:55 ` Stefano Brivio
2019-01-25 10:04 ` Stefano Brivio
2019-01-30 4:51 ` David Ahern
2019-01-30 10:55 ` Stefano Brivio [this message]
2019-01-31 5:12 ` David Ahern
2019-01-31 12:46 ` Stefano Brivio
2019-01-31 12:49 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130115555.61868ab9@redhat.com \
--to=sbrivio@redhat.com \
--cc=buytenh@gnu.org \
--cc=dsahern@gmail.com \
--cc=egarver@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
--cc=todoleza@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).