From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98F41C282D7 for ; Wed, 30 Jan 2019 10:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 736BC20857 for ; Wed, 30 Jan 2019 10:56:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730256AbfA3K4E (ORCPT ); Wed, 30 Jan 2019 05:56:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49460 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727880AbfA3K4D (ORCPT ); Wed, 30 Jan 2019 05:56:03 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E78480F79; Wed, 30 Jan 2019 10:56:03 +0000 (UTC) Received: from localhost (ovpn-200-19.brq.redhat.com [10.40.200.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C3F9D5D96F; Wed, 30 Jan 2019 10:56:00 +0000 (UTC) Date: Wed, 30 Jan 2019 11:55:55 +0100 From: Stefano Brivio To: David Ahern Cc: Phil Sutter , Eric Garver , Tomas Dolezal , Stephen Hemminger , Lennert Buytenhek , netdev@vger.kernel.org Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script Message-ID: <20190130115555.61868ab9@redhat.com> In-Reply-To: <8b930eb8-6ffe-d03f-02a3-12a332edbba3@gmail.com> References: <8b930eb8-6ffe-d03f-02a3-12a332edbba3@gmail.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 30 Jan 2019 10:56:03 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi David, On Tue, 29 Jan 2019 21:51:24 -0700 David Ahern wrote: > On 1/18/19 10:00 AM, Stefano Brivio wrote: > > This script wraps 'ip' and 'bridge' tools to provide a drop-in replacement > > of the standalone 'brctl' utility. > > > > It's bug-to-bug compatible with brctl as of bridge-utils version 1.6, > > has no dependencies other than a POSIX shell, and it's less than half > > the binary size of brctl on x86_64. > > > > As many users (including myself) seem to find brctl usage vastly more > > intuitive than ip-link, possibly due to habit, this might be a lightweight > > approach to provide brctl syntax without the need to maintain bridge-utils > > any longer. > > > > Signed-off-by: Stefano Brivio > > Acked-by: Phil Sutter > > --- > > man/man8/Makefile | 5 +- > > man/man8/ip-brctl.8 | 187 +++++++++++++++ > > misc/Makefile | 9 +- > > misc/ip-brctl.in | 572 ++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 770 insertions(+), 3 deletions(-) > > create mode 100644 man/man8/ip-brctl.8 > > create mode 100755 misc/ip-brctl.in > > I get your intent, but this seems more appropriate for you / Red Hat to > carry than something we want to distribute as part of iproute2. Sure, I could also do that, but: - me creating another project: similar maintenance burden for distribution maintainers as keeping bridge-utils around, for something that won't have any active development - carrying it in a single distribution downstream: I would have gone that way if I thought it wouldn't be useful for others. I myself use (also) distributions other than Fedora/RHEL and this would feel just... wrong Why do you think it's not appropriate to distribute this as part of iproute2? Too ugly? Bloated? Anything I can improve? I think it would be appropriate because it intimately depends on ip-link -- it's really nothing more than a helper for iproute2 tools. -- Stefano