netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Aleksey Makarov <aleksey.makarov@cavium.com>
Cc: netdev@vger.kernel.org, Robert Richter <rric@kernel.org>,
	"Goutham, Sunil" <Sunil.Goutham@cavium.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Radoslaw Biernacki <rad@semihalf.com>,
	linux-kernel@vger.kernel.org,
	David Daney <ddaney@caviumnetworks.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Joe Perches <joe@perches.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v6 1/2] net: add support for Cavium PTP coprocessor
Date: Wed, 30 Jan 2019 08:09:29 -0600	[thread overview]
Message-ID: <20190130140929.GA227269@google.com> (raw)
In-Reply-To: <20180115124500.14872-2-aleksey.makarov@cavium.com>

On Mon, Jan 15, 2018 at 06:44:56PM +0600, Aleksey Makarov wrote:
> From: Radoslaw Biernacki <rad@semihalf.com>
> 
> This patch adds support for the Precision Time Protocol
> Clocks and Timestamping hardware found on Cavium ThunderX
> processors.
> 
> Signed-off-by: Radoslaw Biernacki <rad@semihalf.com>
> Signed-off-by: Aleksey Makarov <aleksey.makarov@cavium.com>
> Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
> ---
>  drivers/net/ethernet/cavium/Kconfig             |  12 +
>  drivers/net/ethernet/cavium/Makefile            |   1 +
>  drivers/net/ethernet/cavium/common/Makefile     |   1 +
>  drivers/net/ethernet/cavium/common/cavium_ptp.c | 353 ++++++++++++++++++++++++
>  drivers/net/ethernet/cavium/common/cavium_ptp.h |  70 +++++
>  5 files changed, 437 insertions(+)
>  create mode 100644 drivers/net/ethernet/cavium/common/Makefile
>  create mode 100644 drivers/net/ethernet/cavium/common/cavium_ptp.c
>  create mode 100644 drivers/net/ethernet/cavium/common/cavium_ptp.h
> 
> diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig
> index 63be75eb34d2..96586c0b4490 100644
> --- a/drivers/net/ethernet/cavium/Kconfig
> +++ b/drivers/net/ethernet/cavium/Kconfig
> @@ -50,6 +50,18 @@ config	THUNDER_NIC_RGX
>  	  This driver supports configuring XCV block of RGX interface
>  	  present on CN81XX chip.
>  
> +config CAVIUM_PTP
> +	tristate "Cavium PTP coprocessor as PTP clock"
> +	depends on 64BIT
> +	imply PTP_1588_CLOCK
> +	default y

Why is this "default y"?

It looks like this is a PCI driver and probably should be loaded only
when the PCI device is present.

> +	---help---
> +	  This driver adds support for the Precision Time Protocol Clocks and
> +	  Timestamping coprocessor (PTP) found on Cavium processors.
> +	  PTP provides timestamping mechanism that is suitable for use in IEEE 1588
> +	  Precision Time Protocol or other purposes.  Timestamps can be used in
> +	  BGX, TNS, GTI, and NIC blocks.

  reply	other threads:[~2019-01-30 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 12:44 [PATCH net-next v6 0/2] net: thunderx: add support for PTP clock Aleksey Makarov
2018-01-15 12:44 ` [PATCH net-next v6 1/2] net: add support for Cavium PTP coprocessor Aleksey Makarov
2019-01-30 14:09   ` Bjorn Helgaas [this message]
2019-01-30 15:06   ` Bjorn Helgaas
2018-01-15 12:44 ` [PATCH net-next v6 2/2] net: thunderx: add timestamping support Aleksey Makarov
2018-01-16 19:31 ` [PATCH net-next v6 0/2] net: thunderx: add support for PTP clock David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130140929.GA227269@google.com \
    --to=helgaas@kernel.org \
    --cc=Sunil.Goutham@cavium.com \
    --cc=aleksey.makarov@cavium.com \
    --cc=ddaney@caviumnetworks.com \
    --cc=joe@perches.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=rad@semihalf.com \
    --cc=richardcochran@gmail.com \
    --cc=rric@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).