From: Bjorn Helgaas <helgaas@kernel.org>
To: Aleksey Makarov <aleksey.makarov@cavium.com>
Cc: netdev@vger.kernel.org, Robert Richter <rric@kernel.org>,
"Goutham, Sunil" <Sunil.Goutham@cavium.com>,
Richard Cochran <richardcochran@gmail.com>,
Radoslaw Biernacki <rad@semihalf.com>,
linux-kernel@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Joe Perches <joe@perches.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v6 1/2] net: add support for Cavium PTP coprocessor
Date: Wed, 30 Jan 2019 09:06:15 -0600 [thread overview]
Message-ID: <20190130150614.GA229773@google.com> (raw)
In-Reply-To: <20180115124500.14872-2-aleksey.makarov@cavium.com>
On Mon, Jan 15, 2018 at 06:44:56PM +0600, Aleksey Makarov wrote:
> +++ b/drivers/net/ethernet/cavium/common/cavium_ptp.c
> @@ -0,0 +1,353 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* cavium_ptp.c - PTP 1588 clock on Cavium hardware
> + * Copyright (c) 2003-2015, 2017 Cavium, Inc.
> + */
> +
> +#include <linux/device.h>
> +#include <linux/module.h>
> +#include <linux/timecounter.h>
> +#include <linux/pci.h>
> +
> +#include "cavium_ptp.h"
> +
> +#define DRV_NAME "Cavium PTP Driver"
This is also unconventional and looks funny, e.g., here:
$ ls /sys/bus/pci/drivers/
8250_mid/ exar_serial/ mei_me/ snd_hda_intel/
agpgart-intel/ i801_smbus/ parport_pc/ snd_soc_skl/
agpgart-sis/ i915/ pcieport/ xen-platform-pci/
agpgart-via/ intel_ish_ipc/ rtsx_pci/ xhci_hcd/
ahci/ intel_pch_thermal/ serial/
'Cavium PTP Driver'/ iosf_mbi_pci/ shpchp/
e1000e/ iwlwifi/ skl_uncore/
next prev parent reply other threads:[~2019-01-30 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 12:44 [PATCH net-next v6 0/2] net: thunderx: add support for PTP clock Aleksey Makarov
2018-01-15 12:44 ` [PATCH net-next v6 1/2] net: add support for Cavium PTP coprocessor Aleksey Makarov
2019-01-30 14:09 ` Bjorn Helgaas
2019-01-30 15:06 ` Bjorn Helgaas [this message]
2018-01-15 12:44 ` [PATCH net-next v6 2/2] net: thunderx: add timestamping support Aleksey Makarov
2018-01-16 19:31 ` [PATCH net-next v6 0/2] net: thunderx: add support for PTP clock David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130150614.GA229773@google.com \
--to=helgaas@kernel.org \
--cc=Sunil.Goutham@cavium.com \
--cc=aleksey.makarov@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=rad@semihalf.com \
--cc=richardcochran@gmail.com \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).