From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D72AC282D7 for ; Wed, 30 Jan 2019 23:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B9CAE20B1F for ; Wed, 30 Jan 2019 23:58:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="kukGlkkO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728279AbfA3X6I (ORCPT ); Wed, 30 Jan 2019 18:58:08 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:35195 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbfA3X6I (ORCPT ); Wed, 30 Jan 2019 18:58:08 -0500 Received: by mail-qk1-f195.google.com with SMTP id w204so903556qka.2 for ; Wed, 30 Jan 2019 15:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=k4m8cG76DzZeG+irHQ6NDvnkc9OnqD+ofRQ9AM+LDJM=; b=kukGlkkOGsdb2O3GzG2bzYhcHDok2uhf8gs0M9UI/fKU0d3LsHOhsFWFSB2EcOtx2B KAFZhd+T4RNIXKlOxiCXIeFsL/vUCHDCAxLY5enn3w2e3AgQNcK9j7HF9+Hh7DJMe7Zp 4R1zFly/wSzLhoiay18kd9S6o0R3IQBoeamuG+Jpt1c6RriGavwwBrvVZWz+wja6zxYV czxqM+29KXHDz9juWKDgiPdb7yWQZ83a2KSvf5iv80gE72PeokNzLAFo4z40B0gxejhK zVEBA/+wF0/3pVBd5zYMLtN5ffVNFGGlS6RgyQua50bi/BllQ7eZ7OiBdHWHTNE5w/u+ Bn9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=k4m8cG76DzZeG+irHQ6NDvnkc9OnqD+ofRQ9AM+LDJM=; b=RFep5Kd2O7PkU/QFr/KCKlEdzCIwcgWZlpaOrz5JXwY8e3sjeAWlvD48s0x8x1Uw7Y SOIkWQmdTUWh/g0Y6S8GGGLmOdgYsJtXQwIWPuM7wB7SIlNDgAud9Cu56BvmVJ76G6j/ HAmsoWpmwMCY5khKoxFqNuvMgpFXOTF0tGNVvfvOImpz2MeOfHO4G0dxzSZDH7oCkh89 aEhlVrqP7hgvhb84ask981eR+p46aWMTpQIzAhX9+f92AxEfTC12KnAD3pvZad7Ijm97 h/wRFllUv4b0ZqfF3GnK6w6XQU8cw1Xh8tfqREaVBBpc2AfFwxCVm9qcNtpz2AWQ/fD/ 3/ag== X-Gm-Message-State: AJcUukfxwNmvuVRcsGG+ANBNHvac5SgxN4U6cAljscsOW3Dsqfwzm5ms /vxmLDr8R+cl5WImc70DQMuaAw== X-Google-Smtp-Source: ALg8bN7Vdm/yt6hfC6G0pAFi3b519vmoMXQOplrN4dB746tytF89YiRyc33zvMHsl6JNf4DKQugfHQ== X-Received: by 2002:a37:7682:: with SMTP id r124mr29680203qkc.79.1548892687490; Wed, 30 Jan 2019 15:58:07 -0800 (PST) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id h31sm4415351qtk.5.2019.01.30.15.58.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 15:58:07 -0800 (PST) Date: Wed, 30 Jan 2019 15:57:58 -0800 From: Jakub Kicinski To: Vasundhara Volam Cc: davem@davemloft.net, michael.chan@broadcom.com, jiri@mellanox.com, mkubecek@suse.cz, netdev@vger.kernel.org Subject: Re: [PATCH net-next v8 0/8] devlink: Add configuration parameters support for devlink_port Message-ID: <20190130155758.3a6be144@cakuba.hsd1.ca.comcast.net> In-Reply-To: <1548678627-21938-1-git-send-email-vasundhara-v.volam@broadcom.com> References: <1548678627-21938-1-git-send-email-vasundhara-v.volam@broadcom.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 28 Jan 2019 18:00:19 +0530, Vasundhara Volam wrote: > This patchset adds support for configuration parameters setting through > devlink_port. Each device registers supported configuration parameters > table. > > The user can retrieve data on these parameters by > "devlink port param show" command and can set new value to a > parameter by "devlink port param set" command. > All configuration modes supported by devlink_dev are supported > by devlink_port also. Hm, I think we were kind of going somewhere with the ethtool/nl attribute encapsulation idea. You seem to have ignored those comments on v7 and reposted v8 a day after. I think we should explore the nesting further. The only obstacle is that ethtool netlink conversion is not yet finished, but that's just a simple matter of programming. Do you disagree with that direction? Please comment.